Repository navigation
fix(sse): scope type-only context errors in combo streams - #15597
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
Responses SSE failures can report context exhaustion in error.type without error.code. Treat those values as request-scoped, matching the stream normalizer. Fixes diegosouzapw#15584
diegosouzapw
merged commit Oct 6, 2026
3bb5259
into
diegosouzapw:release/v3.8.52
51 of 97 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Responses SSE
response.failedevents can report context exhaustion inerror.typewithout anerror.code. The stream normalizer maps these events to HTTP 400, but the combo quality classifier previously checked onlyerror.codewhen deciding whether the failure was request-scoped. As a result, a deterministic input error could be treated as retryable, sent to another connection for the same model, or counted as a model failure.Change
Recognize
context_length_exceededandcontext_window_exceededin eithererror.typeorerror.codeas request-scoped failures. This keeps combo classification aligned with the existing HTTP status normalization; transient upstream errors retain their existing retry behavior. The regression covers both type-only Responses SSE error variants and asserts HTTP 400,requestScoped: true, andretryable: false.Fixes #15584