Repository navigation
fix(quality): allowlist the check-workflows assert reduction from #14497 fail-closed refactor - #15575
Merged
diegosouzapw merged 3 commits intoOct 7, 2026
Conversation
…asking-allowlist-check-workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/quality/test-masking-allowlist.jsonso thecheck:test-maskinggate stops flaggingtests/unit/build/check-workflows.test.ts: asserts 73 -> 67 (REMOCAO de 6).90f81d421f(fix(ci): fail closed on incomplete workflow audits #14497,fix(ci): fail closed on incomplete workflow audits), already onrelease/v3.8.52, authored by the maintainer. That commit migratedparseZizmorOutputfrom graceful-fallback (count=0for empty/invalid/unknown output) to fail-closed (assert.throws) and replaced the quality.yml advisory-build pinning block with the admission-delegation contract. The net-assert reduction follows that legitimate refactor — not masking. Exact case the allowlist is designed for (verified-legitimate refactor, NOT weakening to go green).main, the merge-base reflects the reduced state and the signal no longer fires.Related Issues
check:test-masking/ci.yml:pr-test-policyfailures oncheck-workflows.test.ts).check:agent-skills-syncin 🔴 Release branch not green: release/v3.8.52 #15306 is covered by docs(skills): regenerate the provider endpoints reference #15454 (regeneratesskills/omni-providers/references/endpoints.md) — not duplicated here.Validation
node scripts/check/check-test-masking.mjswithGITHUB_BASE_SHA=origin/mainno longer reportscheck-workflows.test.ts(reduction exempted by the new entry)config/quality/test-masking-allowlist.jsonparses as valid JSONnpm run lint(exit 0)node --import tsx/esm --test tests/unit/build/check-workflows.test.ts: 32/34 on Windows — the 2 failures are the pre-existing CRLF regex bug in the test's workflow-YAML asserts (file untouched by this PR; passes on Linux CI). Non-goal of this PR.Tests Added Or Updated
Coverage Notes
Reviewer Notes
tests/unit/chatcore-sanitization.test.tsv3.8.43 fix(translator): strip orphaned tool results across request formats #5805,tests/unit/combo-context-window-filter.test.tsv3.8.44 fix(combo): prefer known context capacity over unknown #6088).check:agent-skills-sync(docs(skills): regenerate the provider endpoints reference #15454),audit.test.tsflaky CI checkpoint (passes 8/8 locally), suite/runner timeouts andSQLITE_CANTOPEN(infra, not contributor-fixable).