Repository navigation
test(compression): make worker-specifier and RTK TOML assertions cross-platform - #15572
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Conversation
…s-platform The llmlingua worker-specifier test compared URL.pathname to a POSIX literal, which fails on Windows where pathToFileURL resolves to /D:/app/... . The RTK TOML install test asserted 0600 mode bits, which Windows does not implement. Both were test-only bugs; no production code changed. Compare the pathname through pathToFileURL(path.resolve(...)) and gate the mode check on POSIX like tests/unit/data-dir-private-perms.test.ts already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compression-worker-pool-jam.test.ts: comparedURL.pathnameto a POSIX literal (/app/onnxWorker.js). On WindowspathToFileURLresolves to/D:/app/onnxWorker.js→ always failed. Now compares viapathToFileURL(path.resolve(...)).pathname.rtk-toml-compatibility.test.ts: assertedmode & 0o777 === 0o600— Windows has no POSIX mode bits. Gated onprocess.platform !== "win32", same pattern astests/unit/data-dir-private-perms.test.ts. Atomic install + overwrite refusal still runs everywhere.Related Issues
Validation
npm run lint(exit 0)release/v3.8.52Tests Added Or Updated
tests/unit/compression/compression-worker-pool-jam.test.tstests/unit/compression/rtk-toml-compatibility.test.tsCoverage Notes
Reviewer Notes
tests/unit/data-dir-private-perms.test.tsuses{ skip: !posix }.