Repository navigation
fix(combo): lock a model after a local target timeout - #15494
Merged
diegosouzapw merged 2 commits intoOct 6, 2026
Merged
diegosouzapw merged 2 commits into
diegosouzapw merged 2 commits into
Conversation
A combo_target_timeout is request-scoped so it does not trip the provider breaker. The lockout checks used that same flag, so the timed-out model was tried again on the next request. Record the model lockout for that code only. Other request-scoped failures stay unlocked. Related to diegosouzapw#15414. Signed-off-by: Minxi Hou <houminxi@gmail.com>
The lockout change needs its own changelog fragment so release aggregation picks it up. Signed-off-by: Minxi Hou <houminxi@gmail.com>
diegosouzapw
merged commit Oct 6, 2026
866a361
into
diegosouzapw:release/v3.8.52
42 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combo_target_timeout. That code is request-scoped, so the provider circuit breaker stays closed. The model-lockout checks used the same flag and skipped the model too.Validation
node --import tsx/esm --test tests/unit/combo/combo-target-timeout-standards.test.ts tests/unit/combo-model-lockout-honors-reset-1308.test.ts tests/unit/combo/combo-target-exhaustion.test.ts— 68 pass, 0 failreview-default. Each ended PENDING with 0 CONFIRMED. The UNCERTAIN notes restated the lockout branch (first-failure vs exhausted-retry, and whether every request-scoped failure locks). They did not show a missed timeout or a locked context-length failure. The tests cover those two cases.Tests Added Or Updated
tests/unit/combo/combo-target-timeout-standards.test.tscombo_target_timeoutstays request-scoped for the provider breaker and still records a model lockoutcontext_length_exceededstill does not record a model lockoutCoverage Notes
Reviewer Notes
executeTargetAttempt. This change covers the reset-aware path named in the report, not round-robin.