Repository navigation
fix(api): route provider-model handlers through management auth - #15479
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
diegosouzapw
merged commit Oct 6, 2026
4d470c7
into
diegosouzapw:release/v3.8.52
43 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All five /api/provider-models handlers now use requireManagementAuth before parsing request bodies or accessing model state. The reported admin-key 401 remains unverified: the same request passed on the base commit, so this change aligns the route with the centralized management guard but does not establish the deployment failure's cause.
Related Issues
Fixes #15405
Validation
Focused route/auth tests passed (61 tests), management-auth hardening passed (13 tests), API route typecheck passed against its frozen baseline, and formatting plus ESLint checks passed on the checked files. Full CI and the production deployment reproduction were not run.
Tests Added Or Updated
Coverage Notes
Coverage change was not measured.
Reviewer Notes
The repository's bug-fix policy calls for a failing-then-passing test or a documented production test. Neither is available here because the admin-key request also passes on the base; the reported deployment-specific 401 and its cause remain unknown. The focused API typecheck reports 276 diagnostics within the upstream frozen baseline.