Skip to content

perf(i18n): read synced locale keys by direct lookup - #15466

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.52from
maxmad64bis:perf/sync-ui-keys-linear-walk
Oct 6, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.52from
maxmad64bis:perf/sync-ui-keys-linear-walk

Conversation

@maxmad64bis

@maxmad64bis maxmad64bis commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ base-red inherited: #15306

Summary

Syncing UI keys across locales took 93.8 s for 2 new keys across 66 languages. The old path rebuilds the target node and scans it for the key, while the new path reads the key by direct lookup under the existing ownership check. The same timed run finished in 2.8 s with byte-identical output.

Related Issues

  • No linked issue — reproduced on the release base

Validation

  • Change type: i18n
  • Focused tests and category gates from the golden path — focused suites green at the head (30/33 CI gates, 1/1 file tests, red-proof 1 cas); the full unit suite, Vitest, the coverage gate, and the production build run in CI.
  • npm run lint — ESLint on the touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.52 #15306).
  • Reconciled with the current active release base; focused checks rerun afterward — rebased on the current release base; focused tests rerun.
  • Production-code changes include a new or updated automated test in this PR — new regression test added in this PR covering the changed paths.

Tests Added Or Updated

  • tests/unit/i18n-sync-ui-keys-merge.test.ts — covers merging 2 new keys byte for byte against the pre-change snapshot, dropping forbidden prototype keys, reporting no additions when in sync, and covering both shape-mismatch directions.

Coverage Notes

N/A — this PR touches only scripts, tests and changelog, none of src/, open-sse/, electron/ or bin/.

Reviewer Notes

Linear merge replaces the per-key target scan with identical output.
@maxmad64bis
maxmad64bis force-pushed the perf/sync-ui-keys-linear-walk branch from 3eb1dca to 8936123 Compare October 3, 2026 16:34
@maxmad64bis
maxmad64bis marked this pull request as ready for review October 3, 2026 17:16
@diegosouzapw
diegosouzapw merged commit 4fc1402 into diegosouzapw:release/v3.8.52 Oct 6, 2026
122 of 152 checks passed
@maxmad64bis
maxmad64bis deleted the perf/sync-ui-keys-linear-walk branch October 7, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants