Repository navigation
perf(i18n): read synced locale keys by direct lookup - #15466
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
Linear merge replaces the per-key target scan with identical output.
maxmad64bis
force-pushed
the
perf/sync-ui-keys-linear-walk
branch
from
October 3, 2026 16:34
3eb1dca to
8936123
Compare
maxmad64bis
marked this pull request as ready for review
October 3, 2026 17:16
5 tasks
diegosouzapw
merged commit Oct 6, 2026
4fc1402
into
diegosouzapw:release/v3.8.52
122 of 152 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncing UI keys across locales took 93.8 s for 2 new keys across 66 languages. The old path rebuilds the target node and scans it for the key, while the new path reads the key by direct lookup under the existing ownership check. The same timed run finished in 2.8 s with byte-identical output.
Related Issues
Validation
npm run lint— ESLint on the touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.52 #15306).Tests Added Or Updated
Coverage Notes
N/A — this PR touches only scripts, tests and changelog, none of src/, open-sse/, electron/ or bin/.
Reviewer Notes