Repository navigation
fix(cli): send --allow-no-credential to the server - #15416
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Merged
Conversation
The flag only skipped the local prompt. The add-provider request never carried it, and the server schema did not accept it, so a provider that legitimately has no credential was still rejected. The request now includes the flag when it was set, and the server accepts it only for a provider whose catalog says a credential is optional. A request without the flag is checked exactly as before. Signed-off-by: Minxi Hou <houminxi@gmail.com>
HouMinXi
force-pushed
the
fix/allow-no-credential
branch
from
October 6, 2026 13:48
ae70ea4 to
b4ab56a
Compare
diegosouzapw
merged commit Oct 6, 2026
06090d3
into
diegosouzapw:release/v3.8.52
40 of 51 checks passed
rafiknedir9-star
pushed a commit
to rafiknedir9-star/OmniRoute
that referenced
this pull request
Oct 7, 2026
diegosouzapw#15416 added the allowNoCredential check without importing providerAllowsOptionalApiKey, so any request carrying it failed with a ReferenceError (500). Adds a regression test. Also renames CursorExecutor's async header builder to buildCursorHeaders: as an async override of the sync BaseExecutor.buildHeaders it broke the executor registry types (API Route Typecheck).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
providers add --allow-no-credentialonly skipped the local prompt. The request never carried the flag, and the server schema did not accept it, so a provider that legitimately has no credential was still rejected.Related Issues
Validation
node --import tsx/esm --test tests/unit/cli/provider-crud.test.ts(15 pass)eslinton the changed files, with the repo suppression filerelease/v3.8.52@23a1148486Tests Added Or Updated
tests/unit/cli/provider-crud.test.ts(updated)Coverage Notes
Reviewer Notes
buildProviderPayloadhas one production caller, the add command. The schema rejects the flag for a provider that requires a credential, so the flag cannot be used to skip a real requirement.