fix: remove stale compiled dataPaths.js artifact - #1541
Merged
diegosouzapw merged 1 commit intoApr 24, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
Commit 98c5b25 accidentally re-added a compiled CJS output alongside the TypeScript source after the JS→TS migration (9739f41). Webpack resolved the .js file instead of .ts, and ESM interop failed to map the CJS named exports at runtime — crashing the dev server with "resolveDataDir is not a function". Fixes diegosouzapw#1539 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
Thank you for fixing this. Everything looks perfect! |
This was referenced Apr 24, 2026
Closed
Merged
Poid-ZA
pushed a commit
to Poid-ZA/OmniRoute
that referenced
this pull request
Aug 5, 2026
Commit 98c5b25 accidentally re-added a compiled CJS output alongside the TypeScript source after the JS→TS migration (9739f41). Webpack resolved the .js file instead of .ts, and ESM interop failed to map the CJS named exports at runtime — crashing the dev server with "resolveDataDir is not a function". Fixes diegosouzapw#1539 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
Commit 8c14018 accidentally re-added a compiled CJS output alongside the TypeScript source after the JS→TS migration (9739f41). Webpack resolved the .js file instead of .ts, and ESM interop failed to map the CJS named exports at runtime — crashing the dev server with "resolveDataDir is not a function". Fixes diegosouzapw#1539 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1539
Removes
src/lib/dataPaths.js— a compiled CJS artifact accidentally re-committed in98c5b250alongside the TypeScript sourcesrc/lib/dataPaths.ts.Root Cause
The codebase migrated from JS to TypeScript in
9739f413, which renameddataPaths.js→dataPaths.ts. A later refactor commit (98c5b250) re-added the compiled.jsoutput by mistake.With both files present:
dataPaths.js(CJS) instead ofdataPaths.tsresolveDataDirbecomesundefined→ fatal crash on dev server startupChange
src/lib/dataPaths.js— deleted (1 file, 70 lines removed)Test plan
npm run devstarts withoutresolveDataDir is not a functionerrornpm run test:unitpasses (3238 tests)🤖 Generated with Claude Code