Skip to content

fix(rankings): rank only providers from the documented free-model catalog - #15396

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.52from
maxmad64bis:fix/unify-free-provider-lists
Oct 6, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.52from
maxmad64bis:fix/unify-free-provider-lists

Conversation

@maxmad64bis

@maxmad64bis maxmad64bis commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ base-red inherited: #15306

Summary

Before, the free ranking listed every provider carrying the static free flag, so entries with no documented free model still showed up while some documented catalog entries stayed out. The cause was two lists using different rules, with the flag alone deciding the ranking instead of the documented catalog. After, the ranking follows the documented free-model catalog, so both surfaces agree and only providers with a documented free grant are listed.

Related Issues

  • No linked issue — found while comparing the ranking flag with the documented free-model catalog.

Validation

  • Change type: provider
  • Focused tests and category gates from the golden path
  • npm run lint — ESLint on the touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.52 #15306).
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR

Tests Added Or Updated

  • tests/unit/free-provider-rankings-catalog-unification.test.ts — excludes providers with only the static flag, keeps catalog providers with the flag off, and still lists the always-free case.

Coverage Notes

  • src/lib/freeProviderRankings.ts — covered by tests/unit/free-provider-rankings-catalog-unification.test.ts.

Reviewer Notes

  • Behavior: Before, any OAuth or API key entry with the static free flag entered the ranking; after, only entries from the documented free-model catalog enter, so flag-only entries leave and catalog entries join. No migration is needed since the ranking is computed at request time. Catalog entries reachable only through web-cookie sign-in stay outside the ranking because the ranking only walks the three supported auth kinds. This keeps the current page categories unchanged and can be revisited if those kinds are ever listed.

@maxmad64bis
maxmad64bis force-pushed the fix/unify-free-provider-lists branch from 33e5cab to 8c19394 Compare October 2, 2026 22:38
@maxmad64bis
maxmad64bis marked this pull request as ready for review October 3, 2026 01:40
…alog

OAuth/API-key eligibility used the static hasFree flag; now providerHasFreeModels decides.
@maxmad64bis
maxmad64bis force-pushed the fix/unify-free-provider-lists branch from 8c19394 to bffbee8 Compare October 4, 2026 16:21
@diegosouzapw
diegosouzapw merged commit 1063da6 into diegosouzapw:release/v3.8.52 Oct 6, 2026
43 of 85 checks passed
@maxmad64bis
maxmad64bis deleted the fix/unify-free-provider-lists branch October 7, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants