Repository navigation
fix(dashboard): show the message inside a Cloudflare tunnel error object - #15365
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Merged
Conversation
Starting a quick tunnel can be rejected with a structured body whose error field is an object. The endpoint page passed that object straight into new Error, so the notice rendered as [object Object]. The page now reads the message out of the body, and a string error still shows as is. The 403 LOCAL_ONLY itself is intended. The tunnel route spawns a process, so a request that is neither loopback nor private is refused. Signed-off-by: Minxi Hou <houminxi@gmail.com>
diegosouzapw
merged commit Oct 6, 2026
a5a056e
into
diegosouzapw:release/v3.8.52
42 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorfield is an object. The endpoint page passed that object straight intonew Error, so the notice rendered as[object Object]instead of the message inside it.extractApiErrorMessagehelper. A string error still shows as is, and a body with no message falls back to the previous text.Related Issues
Validation
cloudflared-object-error.test.tsx(1 pass) andnode --import tsx/esm --testoncloudflared-object-error.node.test.ts(3 pass)eslinton the changed files, with the repo suppression filerelease/v3.8.52@23a1148486new Error(data?.error || ...)makes both suites fail again, and the change was restoredTests Added Or Updated
src/app/(dashboard)/dashboard/endpoint/__tests__/cloudflared-object-error.test.tsx(added)src/app/(dashboard)/dashboard/endpoint/__tests__/cloudflared-object-error.node.test.ts(added)Coverage Notes
[object Object].Reviewer Notes