Repository navigation
fix(backend): keep TLS fingerprinting when a request carries Next.js metadata - #15364
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Merged
Conversation
…metadata isTlsRequestEligible requires every option key to be on an allow list. RequestInit.next is Next.js cache metadata and was not on it, so any request carrying it silently fell back to a plain fetch and skipped the TLS fingerprint. next is not forwarded to the upstream transport. Other unrecognized keys still bypass fingerprinting. Signed-off-by: Minxi Hou <houminxi@gmail.com>
diegosouzapw
merged commit Oct 6, 2026
2b2e546
into
diegosouzapw:release/v3.8.52
43 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isTlsRequestEligiblerequires every option key to be on an allow list.RequestInit.nextis Next.js cache metadata and was not on the list, so any request carrying it silently fell back to a plain fetch and skipped TLS fingerprinting.nextis now allowed. It is not forwarded to the upstream transport. Any other unrecognized key still bypasses fingerprinting.Related Issues
Validation
node --import tsx/esm --test tests/unit/tls-proxy-context.test.ts(30 pass)eslinton the changed files, with the repo suppression filerelease/v3.8.52@23a1148486next: trueturns the new assertion red with0 !== 1, and the change was restoredTests Added Or Updated
tests/unit/tls-proxy-context.test.ts(updated)Coverage Notes
nextand asserts the request still takes the TLS path and thatnextis not forwarded. A second case carries an unrecognized key and asserts it still bypasses TLS.Reviewer Notes
isTlsRequestEligible, so both are covered by the same change.