Repository navigation
fix(api): log the auto-combo variants GET /api/combos/auto skips instead of failing silently - #15362
Merged
diegosouzapw merged 1 commit intoOct 6, 2026
Conversation
maxmad64bis
force-pushed
the
fix/combos-auto-log-skipped-variants
branch
from
October 2, 2026 16:51
413733e to
bf20663
Compare
…ead of failing silently Silent per-variant catch blocks left skipped variants untraced. The route now logs one line naming the variants that stayed out of the list, and a variant that fails in one loop but builds in a later one is still listed. Covered by injected-failure tests that run in CI.
maxmad64bis
force-pushed
the
fix/combos-auto-log-skipped-variants
branch
from
October 2, 2026 17:57
bf20663 to
f91911e
Compare
4 of 5 tasks
maxmad64bis
marked this pull request as ready for review
October 3, 2026 01:40
diegosouzapw
merged commit Oct 6, 2026
787a67b
into
diegosouzapw:release/v3.8.52
158 of 246 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combo listing sometimes came back short with no log line saying which variant was missing. Each build loop dropped its own failure quietly, so a skipped variant left no trace. The endpoint now logs a single warning naming every variant that stayed out of the list and the first error, while the response stays the same.
Related Issues
Validation
npm run lint— ESLint on the touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.52 #15306).Tests Added Or Updated
tests/unit/combos-auto-skipped-variants.test.ts— injected failure for a named, a template and a tiered-suffix variant (one line, id named once, variant absent), a variant that fails once and builds in a later loop (kept, not reported), the quiet case, payload stability, and a bounded single-line message.catch.Coverage Notes
src/app/api/combos/auto/route.ts— covered bytests/unit/combos-auto-skipped-variants.test.ts(injected failures, retry across loops, quiet case, payload stability, message bounding).Reviewer Notes