Skip to content

fix(ci): register the cycles ratchet script in the gate manifest - #15356

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.52from
HouMinXi:fix/cycles-ratchet-manifest
Oct 6, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.52from
HouMinXi:fix/cycles-ratchet-manifest

Conversation

@HouMinXi

@HouMinXi HouMinXi commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fix(ci): make check-cycles honest — real graph walk + cycles ratchet (#15159 G-01/G-02) #15281 added the check:cycles:ratchet script to package.json but did not register it in config/quality/gate-manifest.json.
  • The pre-commit manifest check requires every check:* script to have a manifest entry, so every commit on this base fails with unmapped alias: check:cycles:ratchet.
  • Register the script next to check:cycles, with the same separately-invoked disposition. It is not added to any execution profile.

Related Issues

Validation

  • Change type: build-deploy (CI gate manifest)
  • node scripts/quality/gate-manifest.mjs exits 0
  • The commit itself passed the pre-commit manifest check that was failing before
  • Reconciled with release/v3.8.52 @ 69cb18dca8
  • No production code changed, so no new test

Tests Added Or Updated

  • None. The change is one manifest entry, and the gate that enforces the manifest passed.

Coverage Notes

  • No production code changed.

Reviewer Notes

  • One file, five lines. The new entry mirrors the existing check:cycles entry and points at node scripts/check/check-cycles.mjs --ratchet.

diegosouzapw#15281 added check:cycles:ratchet to package.json but not to the gate
manifest, so every commit fails the pre-commit manifest check with an
unmapped alias. Register it next to check:cycles as separately-invoked.

Signed-off-by: Minxi Hou <houminxi@gmail.com>
@HouMinXi
HouMinXi requested a review from diegosouzapw as a code owner October 2, 2026 14:41
@diegosouzapw
diegosouzapw merged commit 83b653d into diegosouzapw:release/v3.8.52 Oct 6, 2026
43 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants