Repository navigation
docs: describe check:file-size PR mode accurately - #15345
Merged
diegosouzapw merged 2 commits intoOct 6, 2026
Merged
diegosouzapw merged 2 commits into
diegosouzapw merged 2 commits into
Conversation
QUALITY_GATES.md grouped check:file-size with the new-code mode of complexity-ratchets and dead-code, which diff only the files a PR touched through newCodeMode.mjs. check-file-size.mjs does not use that helper: it reads each file's line count at the PR base and fails a file only when it grows past max(baseline ceiling, base size) (diegosouzapw#8522). Scope the newCodeMode sentence to the two gates that use it, add a file-size paragraph, and fix the gate table row, which named a per-extension cap and left out the test-file gate.
diegosouzapw
merged commit Oct 6, 2026
de762dc
into
diegosouzapw:release/v3.8.52
52 of 97 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skills/omni-providers/SKILL.mdis out of date with its catalog, and unrelated PRs on the same base fail that step too (for example run 37006580278). This PR touches no skill or catalog file.What
docs/architecture/QUALITY_GATES.mdnow describescheck:file-sizeaccurately in two places:scripts/check/newCodeMode.mjs(merge-base worktree, only the files the PR touched) now names the two gates that use it,check:complexity-ratchetsandcheck:dead-code. A new paragraph describes the PR mode ofcheck:file-size.ci.ymllint job table: thecheck:file-sizerow states the actual rule: onecapfor source.ts/.tsxfiles,testCapfor test files, and frozen files must not grow past their recorded size.Why
The doc grouped
check:file-sizewith the new-code mode, butscripts/check/check-file-size.mjsnever importsnewCodeMode.mjs. With--base-refit checks the whole tree: it reads each file's line count at the PR base withgit showand fails a file only when it grows past the larger of its baseline ceiling and its base size (#8522). The table row named a per-extension cap the script does not have and left out the test-file gate.The test-file half of the new paragraph matches #15298, which gives the test-file gate its own base line counts, so this should merge after #15298.
Validation
scripts/check/check-file-size.mjs(evaluateFileSizes,getBaseLoc,collectLoc,collectTestLoc) and the callers ofnewCodeMode.mjs(check-complexity-ratchets.mjs,check-dead-code.mjs,complexityEslintReport.mjs).npm run check:docs-all: pass, includingcheck:fabricated-docs --strict.check-fabricated-docs.mjsskipsdocs/i18n, andcheck:docs-syncvalidates only thellm.txtandCHANGELOG.mdtranslations, so the 66 translated copies of this page are left to the translation workflow.