Repository navigation
fix(dashboard): make the NoAuth egress label map exhaustive + register 7 covering tests - #14939
Merged
Conversation
The label map covered 4 of the 5 EffectiveEgressKind values, so `own` reached
getEgressLabelKey and surfaced as a TS2345 dashboard typecheck regression
("direct" | "own" | "inherited-proxy" | "pool-empty" is not assignable to
"direct" | "inherited-proxy" | "inherited-pool" | "pool-empty").
`own` is only ever built with a proxy attached, so the offending fallthrough is
unreachable at runtime, but the type gap was real and the gate correctly refused
to widen its baseline for it. The map is now typed Record<EffectiveEgressKind,
string>, which makes it exhaustive by construction: adding a kind without a
label is a compile error rather than a latent TS2345. It gains an ownProxy
label alongside the existing four.
Also registers 7 covering unit tests in stryker.conf.json tap.testFiles so
their mutant kills count, clearing the mutation-test-coverage --strict drift
that was failing Fast Quality Gates. check:mutation-test-coverage --strict now
reports no drift.
Contributor
Author
|
Worth knowing before triage: this PR clears The |
diegosouzapw
merged commit Sep 29, 2026
0c6a96d
into
diegosouzapw:release/v3.8.51
12 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two independent base-reds that were failing
Fast Quality Gateson every open PR.1.
NoAuthAccountCard.tsxTS2345EGRESS_LABEL_KEYScovered 4 of the 5EffectiveEgressKindvalues, soownreachedgetEgressLabelKey:The map is now typed
Record<EffectiveEgressKind, string>, so it is exhaustive by construction: adding a kind without a label becomes a compile error instead of a latent TS2345. It gains anownProxylabel next to the existing four.ownis only ever built with a proxy attached, so the offending fallthrough is unreachable at runtime. The type gap was real though, and the gate correctly refused to widen its baseline for a new regression.2.
mutation-test-coverage --strict7 covering unit tests were missing from
stryker.conf.jsontap.testFiles, so their mutant kills were not counting. Each is inserted at its sorted position. The gate now reports no drift.Testing
check:mutation-test-coverage --strict— no drift (was 10 gaps across 5 modules)check:docs-counts— soft-only, so nothing to fix therenoauth-account-cardandnoauth-effective-egresspassdashboard-localization-contractpassI could not run
check:dashboard-typechecklocally:tscOOMs even under a 1 GB cap on this machine, so the type fix is verified by the targeted tests above and CI.