Skip to content

fix(sse): return over-cap bounded read without awaiting tee clone cancel - #14791

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
maxmad64bis:fix/tee-cancel-over-void
Sep 25, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
maxmad64bis:fix/tee-cancel-over-void

Conversation

@maxmad64bis

@maxmad64bis maxmad64bis commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ base-red inherited: #14547

Summary

A buffered turn that exceeds the size cap hangs the request forever: the over-cap branch awaits a tee clone cancel that only settles once the original is read, but the original is piped to the client below. This change returns the verdict without awaiting the cancel, matching the neighboring idle branch.

Related Issues

No linked issue — no upstream report covers the over-cap tee cancel hang (searched tee clone cancel, reader.cancel, emptyTurnRetry over: no open match at a41ded27cc).

Validation

  • Change type: sse
  • Focused tests and category gates from the golden path
  • npm run lint
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR

Tests Added Or Updated

  • tests/unit/flush-empty-retry.test.ts: new regression case with a stream that exceeds the cap and never closes, asserting the outcome returns without waiting.

Coverage Notes

  • The change touches open-sse/utils/emptyTurnRetry.ts; the new regression test covers the over-cap branch, and the neighboring suites stay green.

Reviewer Notes

@maxmad64bis
maxmad64bis marked this pull request as draft September 24, 2026 23:41
@maxmad64bis
maxmad64bis force-pushed the fix/tee-cancel-over-void branch from ee805b7 to 6a6ca22 Compare September 25, 2026 00:23
@maxmad64bis
maxmad64bis marked this pull request as ready for review September 25, 2026 01:01
@diegosouzapw
diegosouzapw merged commit 4f5c0c1 into diegosouzapw:release/v3.8.51 Sep 25, 2026
19 of 25 checks passed
@maxmad64bis
maxmad64bis deleted the fix/tee-cancel-over-void branch September 30, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants