fix(sse): return over-cap bounded read without awaiting tee clone cancel - #14791
Merged
diegosouzapw merged 1 commit intoSep 25, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
maxmad64bis
force-pushed
the
fix/tee-cancel-over-void
branch
from
September 24, 2026 17:41
f877cc6 to
ee805b7
Compare
maxmad64bis
marked this pull request as ready for review
September 24, 2026 17:51
maxmad64bis
marked this pull request as draft
September 24, 2026 23:41
maxmad64bis
force-pushed
the
fix/tee-cancel-over-void
branch
from
September 25, 2026 00:23
ee805b7 to
6a6ca22
Compare
maxmad64bis
marked this pull request as ready for review
September 25, 2026 01:01
diegosouzapw
merged commit Sep 25, 2026
4f5c0c1
into
diegosouzapw:release/v3.8.51
19 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A buffered turn that exceeds the size cap hangs the request forever: the over-cap branch awaits a tee clone cancel that only settles once the original is read, but the original is piped to the client below. This change returns the verdict without awaiting the cancel, matching the neighboring idle branch.
Related Issues
No linked issue — no upstream report covers the over-cap tee cancel hang (searched
tee clone cancel,reader.cancel,emptyTurnRetry over: no open match ata41ded27cc).Validation
npm run lintTests Added Or Updated
tests/unit/flush-empty-retry.test.ts: new regression case with a stream that exceeds the cap and never closes, asserting the outcome returns without waiting.Coverage Notes
open-sse/utils/emptyTurnRetry.ts; the new regression test covers the over-cap branch, and the neighboring suites stay green.Reviewer Notes