feat(sse): record per-request added wait with cause in call logs - #14756
Merged
diegosouzapw merged 6 commits intoSep 25, 2026
Merged
diegosouzapw merged 6 commits into
diegosouzapw merged 6 commits into
Conversation
maxmad64bis
force-pushed
the
fix/request-added-wait
branch
from
September 24, 2026 14:32
9c9e683 to
dae2f60
Compare
maxmad64bis
marked this pull request as ready for review
September 24, 2026 15:12
5 tasks done
maxmad64bis
marked this pull request as draft
September 24, 2026 23:41
5 tasks done
maxmad64bis
force-pushed
the
fix/request-added-wait
branch
from
September 25, 2026 00:36
dae2f60 to
868eb59
Compare
maxmad64bis
force-pushed
the
fix/request-added-wait
branch
from
September 25, 2026 00:51
868eb59 to
f5286dd
Compare
maxmad64bis
marked this pull request as ready for review
September 25, 2026 00:52
5 tasks done
The added-wait p50/p90 helper had no caller and no test; the per-request added_wait_ms/added_wait_cause columns are already surfaced through the call-log route and the request logger. Remove it until a consumer lands.
Merged
5 tasks done
Owner
|
Migration number coordination: several open PRs claim the same slot, and the release tip is already at |
# Conflicts: # config/quality/file-size-baseline.json # open-sse/executors/opencode.ts # open-sse/handlers/chatCore/attemptLogging.ts # src/lib/usage/callLogs.ts
# Conflicts: # config/quality/file-size-baseline.json # open-sse/utils/proxyFetch.ts
diegosouzapw
merged commit Sep 25, 2026
b0cc6ef
into
diegosouzapw:release/v3.8.51
2 of 3 checks passed
diegosouzapw
pushed a commit
that referenced
this pull request
Sep 25, 2026
…14752) Maintainer rework: reconciled with release/v3.8.51 after #14795/#14810/#14756 — migration 193 now follows 190/191/192 with no gap; AGENTS.md / llm.txt / README edits are out of the diff; selectorHelp ICU-escapes the selector=<name> placeholder; ENVIRONMENT.md keeps the tip's PROXY_SKIP_RECENTLY_FAILED default-on row plus this PR's SELECTOR_CONTROL_ALLOWLIST row. Tests: 142/142 focused (proxySubscription selector client/endpoint/functional/guard/help-ICU/schema/strip/trigger/warning, proxy-outcome-memory); typecheck:core and check:open-sse-typecheck clean; eslint clean on changed files; check-file-size and check-migration-numbering OK; no __MISSING__ markers. Thank you @maxmad64bis!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-request latency hides where the wait was suffered: egress pacing and park time never reach the call log, so a slow request cannot be told apart from a slow upstream. A request-scoped accumulator measures the added wait at the dispatch call-site, carries it through the capture sink, and stores it in two nullable columns (
added_wait_ms,added_wait_cause), surfaced in the journal columns and detail view. Null means unmeasured, never zero.Related Issues
No linked issue — per-request added-wait attribution has no prior ticket.
Validation
npm run lintTests Added Or Updated
tests/unit/opencode-added-wait.test.ts(new, 7 tests): off-null, fail-open throttle, park steps non-stream and streaming, abort bounds, zero-wait null, out-of-context null; 7/7 green. Parent suiteopencode-applied-egress-key.test.ts10/10 green on the same head.Coverage Notes
en.jsonkeys (requestLogger.columns.addedWait,requestLogger.detail.addedWait) translated across all 66 locales (check-new-key-coveragePASS).Reviewer Notes
_rebaseline_2026_09_24_14756_request_added_wait):opencode.ts+33,proxyFetch.ts+45,core.ts+2 — call-site measure, sink carry, schema store; nothing else.