Repository navigation
test: realign golden + count pins left stale by the merge wave - #14693
gonisulaimann wants to merge 3 commits into
Conversation
…souzapw#14547) Two deterministic base-red unit failures, both tests left behind by merged features: 1. quota-plan-registry.test.ts pinned knownProviders() at 12 and its includes list predates muse-code. diegosouzapw#14329 added the muse-code plan (13th) without touching the count pin, so every shard fails with 13 !== 12. Pin updated to 13 and muse-code added to the list. 2. provider-translate-path-golden.test.ts regenerating against the deepseek registry restructure (198b3bf): the golden still froze format openai-responses + https://api.deepseek.com/responses as the default path, while the registry now declares openai + /chat/completions (responses remains an alternateFormats entry). Snapshot regenerated via UPDATE_GOLDEN=1; the diff is exactly the deepseek format/url lines. Refs diegosouzapw#14547
|
Thanks for chasing this — confirmed both pins are stale against the current tip ( |
…golden diegosouzapw#14468 retired suno from the registry but left its block in the committed translate-path golden, so the golden test stayed red on the release tip even after the deepseek realignment. Regenerated with UPDATE_GOLDEN=1 against the current registry; the only change is the suno block removal.
|
Thanks for the suno regen on top (493f1d3) — with gemini-business already gone from the rebased snapshot, the golden now matches the registry exactly. Ready for merge. |
|
Thanks @gonisulaimann — after merging the current |
Summary
Fixes the two deterministic unit-test failures red on every
release/v3.8.51run (the failing shards of #14547 not covered by #14511's typecheck work):quota-plan-registry.test.tspinnedknownProviders()at 12 entries; feat(oauth): add Muse Code device login with CLIProxyAPI-parity remint #14329 added the muse-code plan as the 13th without updating the pin, so every CI shard fails13 !== 12. Pin updated to 13 andmuse-codeadded to the includes list.provider-translate-path-golden.test.ts: the committed golden froze deepseek's default asopenai-responses+api.deepseek.com/responses, but the registry restructure in198b3bfd8declaresformat: "openai"+/chat/completionsas the default (responses kept as analternateFormatsentry). The golden is a drift detector forservices/provider.ts, so the snapshot is the side to move. Regenerated withUPDATE_GOLDEN=1— the diff is exactly the deepseek format/url lines, nothing else.Validation
Related Issues
Refs #14547. Complements #14511 (typecheck shard) — no file overlap.
release/v3.8.51tip; none touch this PR's scope. (PR #14693 fixes two of the stale-test failures; #14683 owns the cliproxy typecheck + env-doc pair.)Maintainer rework (merge-batch 2026-09-24)
release/v3.8.51tip into the branch (real merge, your commit untouched). The branch predated fix(providers): retire gemini-business — dead protocol, no live account to validate rewrite (#14217) #14467, so the previous diff against the tip also re-added the retiredgemini-businessblock to the golden; after the merge the tip diff no longer touches it.tests/snapshots/provider/translate-path.jsonwithUPDATE_GOLDEN=1against the current registry: it also still carried thesunoblock retired by fix(providers): retire the suno music provider (#14224) #14468, which kept the golden test red even after the deepseek fix. The final diff against the tip is: deepseekformat/URLs, suno removal, and the 12 → 13knownProviders()pin withmuse-code.provider-translate-path-goldenandquota-plan-registryfail (2 failures); on this head, those two plusagnes-cn-providerandgemini-cli-legacy-refreshpass 38/38.