Skip to content

test: realign golden + count pins left stale by the merge wave - #14693

Closed
gonisulaimann wants to merge 3 commits into
diegosouzapw:release/v3.8.51from
gonisulaimann:fix/unit-base-red-14547
Closed

gonisulaimann wants to merge 3 commits into
diegosouzapw:release/v3.8.51from
gonisulaimann:fix/unit-base-red-14547

Conversation

@gonisulaimann

@gonisulaimann gonisulaimann commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes the two deterministic unit-test failures red on every release/v3.8.51 run (the failing shards of #14547 not covered by #14511's typecheck work):

  1. quota-plan-registry.test.ts pinned knownProviders() at 12 entries; feat(oauth): add Muse Code device login with CLIProxyAPI-parity remint #14329 added the muse-code plan as the 13th without updating the pin, so every CI shard fails 13 !== 12. Pin updated to 13 and muse-code added to the includes list.

  2. provider-translate-path-golden.test.ts: the committed golden froze deepseek's default as openai-responses + api.deepseek.com/responses, but the registry restructure in 198b3bfd8 declares format: "openai" + /chat/completions as the default (responses kept as an alternateFormats entry). The golden is a drift detector for services/provider.ts, so the snapshot is the side to move. Regenerated with UPDATE_GOLDEN=1 — the diff is exactly the deepseek format/url lines, nothing else.

Validation

  • Both suites green locally: quota-plan-registry 14 pass / 0 fail; provider-translate-path-golden 3 pass / 0 fail
  • Golden regenerated, not hand-edited; diff inspected (6 lines, deepseek only)

Related Issues

Refs #14547. Complements #14511 (typecheck shard) — no file overlap.


⚠️ base-red inherited: #14547 — the failing checks (API Route Typecheck, Docs Gates, Unit fast-path shards) also fail on release/v3.8.51 tip; none touch this PR's scope. (PR #14693 fixes two of the stale-test failures; #14683 owns the cliproxy typecheck + env-doc pair.)

Maintainer rework (merge-batch 2026-09-24)

  • Merged the current release/v3.8.51 tip into the branch (real merge, your commit untouched). The branch predated fix(providers): retire gemini-business — dead protocol, no live account to validate rewrite (#14217) #14467, so the previous diff against the tip also re-added the retired gemini-business block to the golden; after the merge the tip diff no longer touches it.
  • Regenerated tests/snapshots/provider/translate-path.json with UPDATE_GOLDEN=1 against the current registry: it also still carried the suno block retired by fix(providers): retire the suno music provider (#14224) #14468, which kept the golden test red even after the deepseek fix. The final diff against the tip is: deepseek format/URLs, suno removal, and the 12 → 13 knownProviders() pin with muse-code.
  • Red → green: with the tip's golden + test file, provider-translate-path-golden and quota-plan-registry fail (2 failures); on this head, those two plus agnes-cn-provider and gemini-cli-legacy-refresh pass 38/38.

…souzapw#14547)

Two deterministic base-red unit failures, both tests left behind by
merged features:

1. quota-plan-registry.test.ts pinned knownProviders() at 12 and its
   includes list predates muse-code. diegosouzapw#14329 added the muse-code plan
   (13th) without touching the count pin, so every shard fails with
   13 !== 12. Pin updated to 13 and muse-code added to the list.

2. provider-translate-path-golden.test.ts regenerating against the
   deepseek registry restructure (198b3bf): the golden still froze
   format openai-responses + https://api.deepseek.com/responses as the
   default path, while the registry now declares openai +
   /chat/completions (responses remains an alternateFormats entry).
   Snapshot regenerated via UPDATE_GOLDEN=1; the diff is exactly the
   deepseek format/url lines.

Refs diegosouzapw#14547
@diegosouzapw

Copy link
Copy Markdown
Owner

Thanks for chasing this — confirmed both pins are stale against the current tip (knownProviders() really is 13 now with muse-code, and deepseek's registry default really is openai/chat/completions). One thing to fix before merge: your branch's merge-base predates #14467 (gemini-business retirement, just landed), so the regenerated golden in this diff also re-adds a "gemini-business" block that no longer exists in the registry. Could you rebase onto the current release tip and regenerate the snapshot from there? After that it should be a clean, deepseek-only diff.

…golden

diegosouzapw#14468 retired suno from the registry but left its block in the committed
translate-path golden, so the golden test stayed red on the release tip even
after the deepseek realignment. Regenerated with UPDATE_GOLDEN=1 against the
current registry; the only change is the suno block removal.
@gonisulaimann

Copy link
Copy Markdown
Contributor Author

Thanks for the suno regen on top (493f1d3) — with gemini-business already gone from the rebased snapshot, the golden now matches the registry exactly. Ready for merge.

@diegosouzapw

Copy link
Copy Markdown
Owner

Thanks @gonisulaimann — after merging the current release/v3.8.51 tip into this branch the diff becomes empty: the tip already realigned the same golden snapshot and count pins (the knownProviders() pin is 13 with muse-code from #14329, and the retired providers left the golden with #14467/#14468). Nothing left to land, so closing as covered — your realignment was correct. (merge-batch 2026-09-24)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants