Repository navigation
security(video): omit echoed cues from retained provider failures - #14527
Merged
diegosouzapw merged 6 commits intoSep 24, 2026
Merged
diegosouzapw merged 6 commits into
diegosouzapw merged 6 commits into
Conversation
diegosouzapw
marked this pull request as ready for review
September 24, 2026 00:49
diegosouzapw
added a commit
that referenced
this pull request
Sep 24, 2026
…irement, extracted failure projection - docs: migration count 182 -> 183 in README, AGENTS.md and llm.txt (+ the 66 llm.txt mirrors), same shape as #14559; migration 185 landed with #14544. - #14468 retired suno: APIKEY_PROVIDERS 242 -> 241 and the translate-path golden loses the suno entry (regenerated; that is the only diff). - #14527 moved the retained provider-failure projection into chatCore/providerFailureRetention.ts; the public-error guard now follows the call and still requires sanitizeErrorMessage() at the projection. Refs #14496
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth isolated FU-05/#11658 retained-sink slice. A classified provider error that echoed a video transcript cue previously stored that cue in provider_connections.lastError. The new projection changes only the retained connection message when the server-owned videoBridgeObserved signal is true; provider classification, connection state and the client-visible error remain unchanged.
VPS 192.168.0.15 public-seam RED at f69ba17: observed lastError retained the sentinel. Exact final PR head 5e090eb passed 25/25 related Node tests, Vitest 482/482 across 51 files with four workers, touched Prettier/ESLint, core typecheck, file-size, new-code complexity and cycles.
Diagnostic integration only, not a published PR head: five-PR tree 2cd03e95753 on release 30f7088 passed 214/214 focused Node tests, Vitest 482/482, core typecheck, file-size, complexity and cycles. Rebased synthetic tree b24a242e40f6 on release 652c4f3 merged without conflict and passed 112/112 changed-file Node tests, Vitest 482/482, core typecheck, file-size, complexity, cycles and test discovery on the VPS.
Full Node, required CI, build/pack and live deployment remain open. The pure release 30f7088 reproduced API typecheck and migration-doc count reds; no red is waived. Refs #11658; this PR does not close the broader retained-sink issue.