Skip to content

test: keep orchestration history fixtures inside a controlled time window #14407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Sep 24, 2026
Merged

test: keep orchestration history fixtures inside a controlled time window #14407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions tests/unit/ui/orchestrationHistoryTab.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/
import React, { act } from "react";
import { createRoot } from "react-dom/client";
import { describe, it, expect, afterEach, vi } from "vitest";
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";

vi.mock("next-intl", () => ({
useTranslations: () => (k: string, v?: Record<string, unknown>) =>
Expand Down Expand Up @@ -50,12 +50,18 @@ afterEach(() => {
document.body.innerHTML = "";
drawerCalls.length = 0;
vi.unstubAllGlobals();
vi.useRealTimers();
});

const NOW = Date.parse("2026-09-01T12:00:00Z");
beforeEach(() => {
// Fixture timestamps and the component's sliding window share one clock.
// Fake Date only: React scheduling and asynchronous fetch flushing stay real.
vi.useFakeTimers({ toFake: ["Date"] });
vi.setSystemTime(NOW);
});
const hoursAgo = (h: number) => new Date(NOW - h * 60 * 60 * 1000).toISOString();
/** Relative to the REAL clock — for assertions that must hold inside the 1d window too
* (the component derives its range from `Date.now()`, not from the fixed `NOW` above). */
/** Relative to the controlled current clock, including explicit time advances. */
const realHoursAgo = (h: number) => new Date(Date.now() - h * 60 * 60 * 1000).toISOString();

function mockFetch(opts: {
Expand Down Expand Up @@ -267,6 +273,8 @@ describe("HistoryTab", () => {
expect((drawerCalls.at(-1) as { node: unknown }).node).toBeTruthy();
const callsBefore = fetchMock.mock.calls.length;

// Completing an action occurs after mount; a new sampled time refreshes the range.
vi.setSystemTime(NOW + 1000);
await act(async () => {
(drawerCalls.at(-1) as { onActionDone: () => void }).onActionDone();
});
Expand Down Expand Up @@ -414,8 +422,8 @@ describe("HistoryTab", () => {
// without leaving/re-entering compare mode.
//
// `buildHistoryGrid` (historyModel.ts) buckets purely client-side by `createdAt` against
// `range`, which is derived from the REAL `Date.now()` (not the fixed `NOW` constant this
// file otherwise uses) — an item outside the requested window is dropped from the grid
// `range`, which is derived from the controlled `Date.now()` — an item outside the
// requested window is dropped from the grid
// entirely, row and all. Both fixtures below use `realHoursAgo` so they survive the
// switch to the 1d preset too; the assertion is about the ring/selection state, not about
// which items the grid happens to still show.
Expand Down
Loading