fix(subscription): serve last known good nodes instead of emptying the pool on fetch or parse failure - #14222
Merged
diegosouzapw merged 1 commit intoSep 22, 2026
Conversation
…e pool on fetch or parse failure
maxmad64bis
force-pushed
the
fix/n104-ingest-lastgood
branch
from
September 19, 2026 22:58
d9cbdd2 to
663ad94
Compare
maxmad64bis
marked this pull request as ready for review
September 19, 2026 23:04
Owner
|
Thanks @maxmad64bis — merging via the release merge-train. Validated in local merge-train (mt-train10c) on the devbox @ train tip 4d841aa1c740bbaa03868dc0a403c62099a99a42 with the 72 sibling PRs of this batch: typecheck:core, file-size, complexity, cognitive-complexity, changelog-integrity green; changed-area node:test 831/831 (0 failing) and vitest 480/482 — the two reds are |
diegosouzapw
merged commit Sep 22, 2026
e4e41ac
into
diegosouzapw:release/v3.8.51
15 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a subscription source fails or returns an unrecognized format, the sync wipes the whole pool and drops the last known good nodes. Failed and invalid syncs now keep the persisted last known good nodes and leave every pool row untouched, while the subscription row itself still records the error.
Related Issues
Validation
npm run lint— targeted ESLint clean; full run is red on the base (same TS2677 pair, inherited, see Reviewer Notes)Tests Added Or Updated
tests/unit/proxySubscription.lastgood.test.ts(new, 4 cases: unrecognized content refused with recognized formats passing, fetch failure serving last nodes with pool untouched, invalid content refused before sync, repeated invalid syncs bumping the counter with pool intact)Coverage Notes
src/lib/proxySubscription/subscriptionService.tsandsrc/lib/proxySubscription/parse.tscovered by the 4 new cases (real 127.0.0.1 servers through the fetch guard and retry path, no stubs); neighborsproxySubscription.service+proxySubscription.parse+proxy-subscription-sync-ownership(19 tests) stay green.Reviewer Notes
format: "unknown"); every recognized format including an empty feed keeps the current path. The existingNO_USABLE_NODESerror code is reused, no new i18n key. The bounded fetch retry is untouched, and tests use real 127.0.0.1 servers with no stubs.typecheck:coreclean, new tests 4/4, neighbors 19/19.release/v3.8.51fails the same 9 jobs (API Route Typecheck, Docs Gates, Fast Quality Gates, Merge integrity, ESLint, Unit fast-path 1-4/4); every file cited by the failing gates is outside this diff. Non-blocking for this PR.