fix(proxy-logs): keep the HTTP status the provider actually returned on search rows - #14220
Merged
diegosouzapw merged 1 commit intoSep 22, 2026
Conversation
maxmad64bis
force-pushed
the
fix/n92-search-upstream-status
branch
from
September 19, 2026 22:54
373f3b6 to
0c3744d
Compare
maxmad64bis
marked this pull request as ready for review
September 19, 2026 22:59
…on search rows Search proxy-log rows always read null (no response received), even when the provider answered with a 429, 403, or 500, so operators could not tell a real refusal from a transport failure. Forward response.status at the four emitEvent call sites; locally synthesized codes (envelope, transport) stay null, matching the chat writer. Verified: new test 6/6 RED-then-GREEN, neighbor search-432 7/7.
maxmad64bis
force-pushed
the
fix/n92-search-upstream-status
branch
from
September 19, 2026 23:10
0c3744d to
15abf90
Compare
Owner
|
Thanks @maxmad64bis — merging via the release merge-train. Validated in local merge-train (mt-train10c) on the devbox @ train tip 4d841aa1c740bbaa03868dc0a403c62099a99a42 with the 72 sibling PRs of this batch: typecheck:core, file-size, complexity, cognitive-complexity, changelog-integrity green; changed-area node:test 831/831 (0 failing) and vitest 480/482 — the two reds are |
diegosouzapw
merged commit Sep 22, 2026
df717be
into
diegosouzapw:release/v3.8.51
7 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search proxy-log rows always read "no response received", even when the provider answered with a 429, 403, or 500. The chat writer already captures the received status; the search writer never forwarded it. After this change, search rows carry the status the provider actually returned, and keep null only when no response arrived.
Related Issues
Validation
npm run lint— ESLint 0 on the two touched source/test files; the fulleslint .run is red on the base, unrelated to this diff.rev-list --count HEAD..upstream/release/v3.8.51= 0, gates re-run after the last amend.tests/unit/search-proxy-upstream-status.test.ts(6 cases, RED-then-GREEN).Tests Added Or Updated
tests/unit/search-proxy-upstream-status.test.ts(6 cases, local HTTP server, journal capture): real 429/200/500 arrive on the row (RED before: null), transport timeout and synthesized envelope codes stay null; neighborsearch-432-plan-limit-cooldown.test.tsstill green (7/7).Coverage Notes
executeProviderFetchis the only search path, so every search provider is covered without a list.Reviewer Notes
Never copies a locally fabricated code into
upstream_status(envelope 402/502, transport 502/504, and post-hoc derived statuses stay null). Local gates: targeted ESLint 0,typecheck:core0, new test 6/6 RED-then-GREEN, C4 re-run at push time (P2 merged, migration 179 present on the base).CI: red jobs are inherited from the red base (🔴 Release branch not green: release/v3.8.51 #13866), not from this diff — the third-party fix: accept ChatGPT cookie headers for clean-room sessions #14219 at the same base fails the same gates (api-typecheck 2 ✖ plus quality/docs/eslint/unit fast-path reds); all three files of this diff are outside the cited files. Non-blocking for this PR.
CI reds are inherited from the red base (🔴 Release branch not green: release/v3.8.51 #13866), not from this diff: the third-party PR fix(sse): treat antigravity empty completions with a normal stop as valid 200s (#14160) #14243 on the same base
release/v3.8.51fails the same 9 jobs (API Route Typecheck, Docs Gates, Fast Quality Gates, Merge integrity, ESLint, Unit fast-path 1-4/4); every file cited by the failing gates is outside this diff. Non-blocking for this PR.