Skip to content

fix(routing): honor manual auto weights and weight weekly reset urgency higher - #14176

Merged
diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.51from
JxnLexn:dev/weekly-reset-priority
Sep 22, 2026
Merged

diegosouzapw merged 3 commits into
diegosouzapw:release/v3.8.51from
JxnLexn:dev/weekly-reset-priority

Conversation

@JxnLexn

@JxnLexn JxnLexn commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Problem and change

Editing Auto routing factor sliders leaves the previous mode pack selected. A combo saved with ship-fast and a nonzero reset-window weight therefore still runs with the preset's zero reset weight. Manual factor edits now select custom, while unrelated edits preserve the selected preset and additional combo configuration. Explicit preset selection continues to work.

Auto reset affinity now combines weekly urgency (65%) and session urgency (35%), each normalized to its window duration. Missing windows are excluded from the weighted average; explicit window selections remain respected. This stays a weighted Auto factor, not a strict account ordering. The separate reset-window strategy is unchanged.

Validation

  • 24 focused Node tests covering configuration, Auto candidate evaluation, reset-window routing, manual weight edits and the 65/35 calculation.
  • Editor interaction regression test: changing a factor selects custom scoring and preserves additional configuration.
  • Core TypeScript check and focused ESLint passed.
  • Full Vitest suite passed on the release baseline (482 tests); the integrated fork suite passed (405 tests).
  • The full Node suite is not green: failures were observed in other areas including catalog-count assertions, Bifrost relay, binary management and repository checks. No claim of a clean full-suite run.
  • Equivalent isolated changes are deployed in the fork. A live Responses request through a Codex Auto combo returned HTTP 200 and OK; saved custom scoring was verified. That smoke test validates execution, not the 65/35 ranking itself, which is covered by automated tests.

Existing saved presets are not migrated automatically. Operators who intend to use their stored manual weights should select Custom or edit a factor. The independent account-cooldown fix in #14175 is not included.

@diegosouzapw

Copy link
Copy Markdown
Owner

Thanks @JxnLexn — merging via the release merge-train. Validated in local merge-train (mt-train10c) on the devbox @ train tip 4d841aa1c740bbaa03868dc0a403c62099a99a42 with the 72 sibling PRs of this batch: typecheck:core, file-size, complexity, cognitive-complexity, changelog-integrity green; changed-area node:test 831/831 (0 failing) and vitest 480/482 — the two reds are autoCombo/provider-family-combos.test.ts timing out at 20s, which reproduces on the PURE release tip under the full vitest suite (and is already tracked by the Release-Green issue #13866), so it is inherited, not this batch's. Merged --admin per merge-gates §3/§4/§7.

@diegosouzapw
diegosouzapw merged commit 5229a40 into diegosouzapw:release/v3.8.51 Sep 22, 2026
7 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants