docs: name combo hang-stop from comboPredicates.ts - #14054
Conversation
|
This PR documents both gaps that make
If #14022 lands first, this PR rebases and drops the STRIP overlap, keeping only the constant prose change. |
|
#14004 closed itself after #14022 is already on that tip. It documents This PR's leftover vs current tip is the STRIP overlap plus a prose rewrite of the hang-stop sentence. The allowlist already covers that name, so the rewrite is unused. Closing as superseded by #14022. Related to #14004. The issue is already closed. |
|
Reopened. I closed this by mistake; that call is the maintainer's. #14022 already landed on |
20f438b to
f37f1bb
Compare
|
Rebased onto STRIP documentation is already on the branch. The remaining unique diff is the Local #14004 stays with whoever owns the tracker. |
f37f1bb to
9ce8fec
Compare
|
Rebased onto current |
diegosouzapw#14022 already documented OMNIROUTE_STRIP_SYSTEM_PREAMBLE and allowlisted COMBO_LOOP_SAFETY_TIMEOUT_MS. The remaining mismatch is the ENVIRONMENT.md sentence that still backticks the constant as if it were operator-facing. Signed-off-by: Minxi Hou <houminxi@gmail.com>
9ce8fec to
43952e6
Compare
|
Thanks @HouMinXi — merging via the release merge-train. Validated in local merge-train (mt-train10c) on the devbox @ train tip 4d841aa1c740bbaa03868dc0a403c62099a99a42 with the 72 sibling PRs of this batch: typecheck:core, file-size, complexity, cognitive-complexity, changelog-integrity green; changed-area node:test 831/831 (0 failing) and vitest 480/482 — the two reds are |
d46d4d8
into
diegosouzapw:release/v3.8.51
Related to #14004. The tracker already closed after
7cc454d93went release-green.#14022 landed the STRIP documentation and the
DOC_ONLY_ALLOWLISTentry forCOMBO_LOOP_SAFETY_TIMEOUT_MS. Rebased onto that tip; the STRIP overlap is gone.What is left:
ENVIRONMENT.mdno longer backticks the hang-stop constant as an env name. It points atcomboPredicates.tsinstead. The allowlist already keeps the checker green; this is the prose form of the same fact.node scripts/check/check-env-doc-sync.mjson this tree: 613 / 825 / 842, all three directions none, exit 0.