chore(quality): rebaseline the last ceiling the 09-17 merge wave moved - #14016
Merged
diegosouzapw merged 2 commits intoSep 18, 2026
Merged
Conversation
diegosouzapw
changed the title
tests/unit/chatcore-translation-paths.test.ts 3447 -> 3449, from #13173 (Fable mid-conversation cache prefixes — the new assertions for that case). This is the only one left. The other two this PR originally carried (chatHelpers.ts and chatCore.ts) were absorbed by the rebaselines the merging PRs brought with them, so the branch was rebuilt on the current tip rather than shipping stale numbers. Measured clean: check:file-size and test-file-size both pass with no violations.
diegosouzapw
force-pushed
the
fix/release-v3.8.51-basereds-0917c
branch
from
September 17, 2026 22:37
4d4fef0 to
fbd9e82
Compare
diegosouzapw
changed the title
This was referenced Sep 18, 2026
fix(compression): repair the unit-test base-reds left by the 09-17 merge wave (RTK + goldens)
#14082
Merged
Owner
Author
|
Validated in local merge-train /tmp/mt-basereds.log on 192.168.0.113 @ train tip c2fb6404606064c56520d7b2a148e8770dc70cd0 (boarded #14022 #14016 #14079 #14082): static gates green; test:unit 40635 tests, 17 failing — every one reproduces on the pure release tip 1603c86 (41 failing there; list in the base-red sweep), zero new reds. Merged with --admin per merge-gates §4/§7 (inherited base-reds only). |
diegosouzapw
added a commit
that referenced
this pull request
Sep 18, 2026
…rge wave (#14082) Every PR against release/v3.8.51 is born red on all four Unit Tests fast-path shards. Reproduced on the pure tip (1603c86): ~35 tests. This commit repairs the two large clusters plus the stale assertions sharing their root cause (17 tests); the rest is tracked separately. RTK (12 tests, real regression): #13521 gated dedup on skipFilters || isDocumentLikeRead but isDocumentLikeRead is true for ANY text whose type detection is unknown — not only non-shell tool results — so plain repeated tool output (the classic RTK case) stopped being deduplicated, processRtkText returned no stats, and rtkEngine.apply().stats.engine came back undefined. The intent of #13388 was the non-shell-tool skip, which resolveToolMeta already expresses as skipFilters; dedup now honours only that. The #13521 regression guard (rtk-file-content-preservation, tool named 'read' → skipFilters) still passes 4/4; rtk-engine is back to 9/9. Golden + stale assertions (5 tests, product changes never propagated): - tests/snapshots/provider/translate-path.json: xKiro (#12648) was added to the registry without regenerating the snapshot — purely additive entry. - providers-constants-split: APIKEY_PROVIDER_COUNT 241 → 242 (xKiro). - tests/snapshots/g13/combo-chatcore-public-seams.json and the three Content-Type assertions in chatcore-translation-paths / chat-route-coverage: #13419 deliberately made streaming responses declare 'text/event-stream; charset=utf-8' (Arabic/Persian mojibake) and updated the integration test but not these unit assertions. Before/after on the 26 base-red files: 266 tests, 23 → 18 failing here (the RTK suites were counted per-file in CI; per-test this is 17 fixed). The file-size ✗ on chatcore-translation-paths.test.ts is the pre-existing drift #14016 rebaselines — this commit keeps that file's line count unchanged.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
diegosouzapw#14016) tests/unit/chatcore-translation-paths.test.ts 3447 -> 3449, from diegosouzapw#13173 (Fable mid-conversation cache prefixes — the new assertions for that case). This is the only one left. The other two this PR originally carried (chatHelpers.ts and chatCore.ts) were absorbed by the rebaselines the merging PRs brought with them, so the branch was rebuilt on the current tip rather than shipping stale numbers. Measured clean: check:file-size and test-file-size both pass with no violations.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…rge wave (diegosouzapw#14082) Every PR against release/v3.8.51 is born red on all four Unit Tests fast-path shards. Reproduced on the pure tip (3ce81a1): ~35 tests. This commit repairs the two large clusters plus the stale assertions sharing their root cause (17 tests); the rest is tracked separately. RTK (12 tests, real regression): diegosouzapw#13521 gated dedup on skipFilters || isDocumentLikeRead but isDocumentLikeRead is true for ANY text whose type detection is unknown — not only non-shell tool results — so plain repeated tool output (the classic RTK case) stopped being deduplicated, processRtkText returned no stats, and rtkEngine.apply().stats.engine came back undefined. The intent of diegosouzapw#13388 was the non-shell-tool skip, which resolveToolMeta already expresses as skipFilters; dedup now honours only that. The diegosouzapw#13521 regression guard (rtk-file-content-preservation, tool named 'read' → skipFilters) still passes 4/4; rtk-engine is back to 9/9. Golden + stale assertions (5 tests, product changes never propagated): - tests/snapshots/provider/translate-path.json: xKiro (diegosouzapw#12648) was added to the registry without regenerating the snapshot — purely additive entry. - providers-constants-split: APIKEY_PROVIDER_COUNT 241 → 242 (xKiro). - tests/snapshots/g13/combo-chatcore-public-seams.json and the three Content-Type assertions in chatcore-translation-paths / chat-route-coverage: diegosouzapw#13419 deliberately made streaming responses declare 'text/event-stream; charset=utf-8' (Arabic/Persian mojibake) and updated the integration test but not these unit assertions. Before/after on the 26 base-red files: 266 tests, 23 → 18 failing here (the RTK suites were counted per-file in CI; per-test this is 17 fixed). The file-size ✗ on chatcore-translation-paths.test.ts is the pre-existing drift diegosouzapw#14016 rebaselines — this commit keeps that file's line count unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Único teto remanescente da leva de merges de 2026-09-17.
tests/unit/chatcore-translation-paths.test.ts3447 → 3449, vindo da #13173 (prefixos de cache de meio de conversa do Fable — as asserções novas daquele caso).Por que a PR encolheu
Ela carregava três tetos. Os outros dois —
src/sse/handlers/chatHelpers.tseopen-sse/handlers/chatCore.ts— foram absorvidos pelos rebaselines que as próprias PRs trouxeram ao mergear depois (a #13720 levou ochatHelpersa 1253, e ochatCorevoltou a caber no teto vigente). Em vez de mergear números obsoletos, refiz o branch sobre o tip atual.Medido limpo no tip
176d632a:Registrado, fora de escopo
tests/unit/chatcore-translation-paths.test.tstem duas falhas de header (buildStreamingResponseHeaders drops upstream compression and framing headersechatCore strips upstream compression and length headers from streaming responses). Reproduzi as duas em2fa6ef0b, anterior a toda esta leva — é base-red antigo, precisa de investigação própria e não é tratado aqui.