Skip to content

fix(tests): bump the APIKEY_PROVIDERS tripwire to 241 (Agnes AI China) - #13905

Merged
diegosouzapw merged 1 commit into
release/v3.8.51from
fix/release-v3.8.51-basereds-apikey-count
Sep 16, 2026
Merged

diegosouzapw merged 1 commit into
release/v3.8.51from
fix/release-v3.8.51-basereds-apikey-count

Conversation

@diegosouzapw

Copy link
Copy Markdown
Owner

APIKEY_PROVIDERS merges the 6 family files into 240 entries (no loss / no dup) fails on the
release tip, which takes a unit-test shard red on every open PR against release/v3.8.51.

Cause: Agnes AI China (#13399, cdcde97c7) added one apikey/regional entry. The real count
is 241 — confirmed at runtime:

Object.keys(APIKEY_PROVIDERS).length -> 241   (includes `agnes-cn`)

Why not make it dynamic: the hardcoded number is the point. The test is a tripwire against
silent loss or duplication across the six family files; deriving the count at runtime would make it
assert nothing. The header documents every bump with the provider and the PR that caused it
(… SeekAi … 238, … GreenPT and EURouter … 240), so this follows the same convention with a new
line for Agnes AI.

Local: 4/4 in tests/unit/providers-constants-split.test.ts.

Not covered by #13880 (@HouMinXi), which heals the agent-skills sync and the reasoning-effort test —
this is a third, independent base red in the same wave.

`APIKEY_PROVIDERS merges the 6 family files into 240 entries` fails on the
release tip, taking a unit-test shard red on every open PR.

Agnes AI China (#13399, cdcde97) added one `apikey/regional` entry, so the
real count is 241 — confirmed at runtime: `Object.keys(APIKEY_PROVIDERS).length`
is 241 and includes `agnes-cn`.

The hardcoded number is deliberate, not an oversight: the test is a tripwire for
silent loss or duplication across the six family files, and each bump is
documented in the header with the provider and the PR that caused it. Kept that
convention rather than deriving the count at runtime, which would make the test
assert nothing.
@diegosouzapw
diegosouzapw merged commit 86b8bbf into release/v3.8.51 Sep 16, 2026
8 of 11 checks passed
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
diegosouzapw#13905)

`APIKEY_PROVIDERS merges the 6 family files into 240 entries` fails on the
release tip, taking a unit-test shard red on every open PR.

Agnes AI China (diegosouzapw#13399, 517c4cf) added one `apikey/regional` entry, so the
real count is 241 — confirmed at runtime: `Object.keys(APIKEY_PROVIDERS).length`
is 241 and includes `agnes-cn`.

The hardcoded number is deliberate, not an oversight: the test is a tripwire for
silent loss or duplication across the six family files, and each bump is
documented in the header with the provider and the PR that caused it. Kept that
convention rather than deriving the count at runtime, which would make the test
assert nothing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant