fix(ci): bound the forgotten-sibling report so an advisory step stops failing the job - #13889
Merged
diegosouzapw merged 1 commit intoSep 16, 2026
Conversation
… failing the job
"Fast Quality Gates" is red on every open PR against release/v3.8.51. The failing
step is `forgotten-sibling-tests`, which is explicitly advisory — its own output
says "Report-only calibration: these findings do not fail the job" — yet it exits 1.
When a PR diff touches a hub module (`open-sse/config/providerRegistry.ts` in the
current reds), the analysis walks every import edge in the repo and multiplies each
consumer by its candidate tests. The result reaches millions of rows, and
`lines.join("\n")` then exceeds V8's maximum string length. The throw lands in
main()'s catch, which exits 1 — so an advisory report takes the whole job down.
Measured with a synthetic hub cross-product, before the change:
3,000,000 findings -> a 435 MB report string (no throw, but absurd)
4,500,000 findings -> Invalid string length (the CI failure, verbatim)
After: the same 4,500,000 findings render as 27 KB.
The fix bounds only the ENUMERATION. The header keeps the exact totals, so the
signal ("this diff has N unreviewed sibling tests") is unchanged; at most 200 rows
per section are listed, followed by a line naming how many were withheld. The JSON
artifact gets the same treatment (5,000 items per array) plus an explicit `totals`
object, since `JSON.stringify` would throw on the same input for the same reason.
`markdown()` is exported so the bound is testable without a CI-sized diff.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… failing the job (diegosouzapw#13889) "Fast Quality Gates" is red on every open PR against release/v3.8.51. The failing step is `forgotten-sibling-tests`, which is explicitly advisory — its own output says "Report-only calibration: these findings do not fail the job" — yet it exits 1. When a PR diff touches a hub module (`open-sse/config/providerRegistry.ts` in the current reds), the analysis walks every import edge in the repo and multiplies each consumer by its candidate tests. The result reaches millions of rows, and `lines.join("\n")` then exceeds V8's maximum string length. The throw lands in main()'s catch, which exits 1 — so an advisory report takes the whole job down. Measured with a synthetic hub cross-product, before the change: 3,000,000 findings -> a 435 MB report string (no throw, but absurd) 4,500,000 findings -> Invalid string length (the CI failure, verbatim) After: the same 4,500,000 findings render as 27 KB. The fix bounds only the ENUMERATION. The header keeps the exact totals, so the signal ("this diff has N unreviewed sibling tests") is unchanged; at most 200 rows per section are listed, followed by a line naming how many were withheld. The JSON artifact gets the same treatment (5,000 items per array) plus an explicit `totals` object, since `JSON.stringify` would throw on the same input for the same reason. `markdown()` is exported so the bound is testable without a CI-sized diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Fast Quality Gates" is currently red on every open PR against
release/v3.8.51. The failingstep is
forgotten-sibling-tests— which is explicitly advisory; its own output says"Report-only calibration: these findings do not fail the job." — yet it exits 1.
Why
When a diff touches a hub module (
open-sse/config/providerRegistry.tsin the current reds), theanalysis walks every import edge in the repo and multiplies each consumer by its candidate tests.
The cross-product reaches millions of rows, and
lines.join("\n")then exceeds V8's maximum stringlength. The throw lands in
main()'s catch, which exits 1 — so an advisory report takes the wholejob down, on PRs that have nothing to do with it.
Measured with a synthetic hub cross-product against the current script:
Invalid string length— the CI failure, verbatimWith this change the same 4 500 000 findings render as 27 KB.
What changed
Only the enumeration is bounded — never the signal:
Unallowlisted findings: 4500000in the probe above);totalsobject —
JSON.stringifywould throw on the same input for the same reason;markdown()is exported so the bound is testable without a CI-sized diff.No change to the analysis, the allowlist, or what counts as a finding.
Note
This is the second base-red in a row from the same family: #13875 fixed the env/docs contract, and
this one clears the remaining always-red gate. Both are infrastructure, not product defects.