fix(i18n): pt-BR review pass over the retranslated leaves (172 corrections) + review-locale script - #13885
Merged
Conversation
diegosouzapw
added a commit
that referenced
this pull request
Sep 18, 2026
… quality (#14078) * fix(i18n): review-locale reviews every leaf of a catalog that did not exist at --since * fix(i18n): review the 64 non-pt-BR dashboard catalogs for translation quality Runs scripts/i18n/review-locale.mjs over every locale except pt-BR (done in #13885): 75,263 corrections applied against the English source, 1,677 of them reverted because the "correction" replaced a real translation with the plain English term (the real-translation ratio gate counts those as untranslated). zh-CN/zh-TW provider term normalised after the run. review-locale.mjs hardening found by the run: per-batch retries with backoff (a skipped batch is listed, not fatal), catalog checkpoint every 25 batches, and setDeep resolving leaf keys that contain a dot.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…tions) + review-locale script (diegosouzapw#13885) Reviewer pass (native-speaker prompt) over the 1,865 pt-BR leaves retranslated in diegosouzapw#13782: 172 corrections applied; new scripts/i18n/review-locale.mjs with tests.⚠️ base-red inherited: diegosouzapw#12732
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… quality (diegosouzapw#14078) * fix(i18n): review-locale reviews every leaf of a catalog that did not exist at --since * fix(i18n): review the 64 non-pt-BR dashboard catalogs for translation quality Runs scripts/i18n/review-locale.mjs over every locale except pt-BR (done in diegosouzapw#13885): 75,263 corrections applied against the English source, 1,677 of them reverted because the "correction" replaced a real translation with the plain English term (the real-translation ratio gate counts those as untranslated). zh-CN/zh-TW provider term normalised after the run. review-locale.mjs hardening found by the run: per-batch retries with backoff (a skipped batch is listed, not fatal), catalog checkpoint every 25 batches, and setDeep resolving leaf keys that contain a dot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task 8 of the i18n completion plan. PR #13782 retranslated 1,865 pt-BR leaves by machine; this PR sends exactly those leaves through a reviewer pass (native-speaker prompt, dashboard context, placeholders/ICU/product names preserved) and applies only the corrections it returns.
scripts/i18n/review-locale.mjs(--locale=<code> --since=<git ref> [--dry-run] [--batch-size=30]): exportschangedLeaves(before, after)andparseReviewResponse(text, ids); loads the repo.envlikesync-ui-keys; writes the catalog in place and a markdown report (_artifacts/i18n-review/<code>.md, untracked). Test:tests/unit/i18n-review-locale.test.ts(3 cases).src/i18n/messages/pt-BR.json: 172 corrections out of 1,865 reviewed leaves.Validation
i18n-review-locale,i18n-pt-br,i18n-placeholder-parity,i18n-cli-namespaces,server-owned-tool-loop-flag,i18n-home-recent-requests-topology-legendnpm run i18n:check-ratioSample of the corrections:
common.retriescommon.expirationBannerExpiringSooncommon.safeSearchModeratecommon.disableConfirm