Repository navigation
fix(sse): emit valid responses keepalives - #13850
TheDemonTuan wants to merge 1 commit into
Conversation
|
Re-reviewed this against the fuller bug report that has since landed (#14330), and two things need First, the new keepalive shape bypasses the opt-out from #10524. The gate at Second, #14330's third criterion is the invalid failure frames, and this PR doesn't touch them: One coordination note: #14377 asks for the keepalive shape to be configurable, which this PR |
|
Thanks @TheDemonTuan for chasing the invalid Responses keepalive frames (#14330). You were right that the synthetic #14572 (merged 2026-09-24) fixed this on If you hit a client that still rejects the frames the tip sends now, please open an issue with a capture. We'll look at it against the current design. |
Summary
response.in_progressheartbeat events with SSE commentsVerification
node --import tsx/esm --test tests/unit/sseHeartbeat.test.ts tests/unit/sse-heartbeat.test.ts tests/unit/earlyStreamKeepalive.test.ts tests/unit/early-stream-keepalive.test.ts tests/unit/chatcore-streaming-pipeline.test.ts tests/unit/responses-route-early-keepalive-wiring.test.ts(all passed)