fix(tests): chain serial quarantine step in npm test (#13286) - #13418
Merged
diegosouzapw merged 1 commit intoSep 15, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
…apw#13286) The 'test' script was the only parallel runner that did not chain npm run test:unit:serial, so serial-quarantined tests were silently skipped. Added the missing chain and updated the guard test to cover the 'test' runner.
KooshaPari
force-pushed
the
pr/13286-npm-test-serial
branch
from
September 13, 2026 08:42
3cf1e77 to
a16dad6
Compare
diegosouzapw
merged commit Sep 15, 2026
67cb0ac
into
diegosouzapw:release/v3.8.51
8 of 16 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…apw#13286) (diegosouzapw#13418) Chains `npm run test:unit:serial` onto the plain `npm test` script, so the quarantined serial suite is no longer skipped when contributors run `npm test` (diegosouzapw#13286). The existing `test-serial-quarantine` guard now covers `test` too. Validated in one consolidated batch of this series (37 PRs boarded together on `release/v3.8.51`): `typecheck:core`, `check:open-sse-typecheck` and `check:dashboard-typecheck` clean; ESLint clean on every changed file; file-size, complexity, cognitive-complexity, changelog-integrity, docs-counts, docs-sync and migration-numbering gates green (only the pre-existing `open-sse/utils/stream.ts` file-size red remains, inherited from the base); 3,743 focused `node:test` cases plus 34 vitest cases green. Thanks @KooshaPari!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm testwas the only test runner that did not chain the serial quarantine step (&& npm run test:unit:serial), silently skipping the quarantined test files intests/unit/serial/**/*.test.ts. A developer running plainnpm testgot a green result without ever executing them.test:unit:serialtesttest:unittest:unit:citest:unit:fasttest:coverage:runnerThe guard test (
test-serial-quarantine.test.ts) also did not includetestin its list of runners to check, so the gap was invisible to CI.Fix
&& npm run test:unit:serialto thetestscript inpackage.json"test"to the guard test's runner list intest-serial-quarantine.test.tsVerification
All 4 guard tests pass after the fix.
Closes #13286