Repository navigation
chore(quality): drop two stale ESLint suppression entries - #13384
Merged
Merged
Conversation
#12653 and #12358 fixed the violations these covered but left the entries behind, and eslint treats a suppression with nothing left to suppress as an error. That blocks the pre-commit hook on any commit whose staged set includes either file. - open-sse/services/imageCombo.ts (no-unused-vars) - tests/unit/chat-helpers.test.ts (no-explicit-any) A ratchet tightening, not a rebaseline: both counts go to zero by deletion. The three no-explicit-any errors remaining in tests/unit/volcengine-plan-binding-upsert.test.ts are untouched here — that is the pre-existing base-red #13215 tracks.
Githab-capibara
added a commit
to Githab-capibara/OmniRoute
that referenced
this pull request
Sep 17, 2026
…pw#13384) Unblocks the pre-commit hook; both suppressions had nothing left to suppress.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…pw#13384) Unblocks the pre-commit hook; both suppressions had nothing left to suppress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12653 and #12358 fixed the violations these entries covered but left the entries in place, and ESLint treats a suppression with nothing left to suppress as an error. The practical effect is that the pre-commit hook rejects any commit whose staged set includes either file — which is how I found it, reconciling a PR against the tip.
open-sse/services/imageCombo.ts—no-unused-varstests/unit/chat-helpers.test.ts—no-explicit-anyBoth are deleted rather than re-counted, so this tightens the ratchet.
Not touched here: the three
no-explicit-anyerrors intests/unit/volcengine-plan-binding-upsert.test.ts, which makenpm run lintexit 2 on the pure tip today. Issue #13215 is closed but that red is still live onrelease/v3.8.51.