Repository navigation
test(compression): assert idle eviction terminates at the resource level - #13371
Merged
diegosouzapw merged 1 commit intoSep 11, 2026
Merged
Conversation
#13091 fixed the idle-eviction leak and guards it by asserting the worker's `exit` event fires. This adds the complementary angle from #12542: it counts actual `terminate()` calls and checks `process.getActiveResourcesInfo()` does not retain the worker's MessagePort, so a regression that drops the slot without releasing the OS-level handle is caught too. Verified both directions on the current tip: 8/8 with the fix in place, and the new case alone fails when `remove()` is made to skip `terminate()`. Co-authored-by: pacocartones <pacocartones@users.noreply.github.com>
4 of 5 tasks
Githab-capibara
added a commit
to Githab-capibara/OmniRoute
that referenced
this pull request
Sep 17, 2026
…vel (diegosouzapw#13371) Merged as the credit vehicle for diegosouzapw#12542. Reverse-TDD verified on the tip: 8/8 with the fix, 7/8 with `terminate()` disabled.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…vel (diegosouzapw#13371) Merged as the credit vehicle for diegosouzapw#12542. Reverse-TDD verified on the tip: 8/8 with the fix, 7/8 with `terminate()` disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries the test case from #12542 by @pacocartones, whose fix was subsumed by #13091 (merged earlier today, same diagnosis reached independently).
#13091 guards the idle-eviction leak by asserting the worker's
exitevent fires — that is what separates a terminated thread from a merely dereferenced one. This adds the complementary, resource-level angle: it counts actualterminate()calls and checks thatprocess.getActiveResourcesInfo()does not retain the worker'sMessagePort. A regression that drops the slot while leaving the OS handle alive is caught by this one and not by the other.Verified both directions on the current tip:
Test-only, plus a maintenance changelog fragment.