Repository navigation
chore(electron): prune the root-level files of every translated docs mirror from the desktop bundle - #13235
Merged
Conversation
…mirror The desktop runtime reads exactly one slice of docs/i18n: the translated docs/** tree, through the in-app docs route (src/lib/docsI18nPath.ts pins the path). Each locale's root-level mirrors — README.md, llm.txt, CLAUDE.md, GEMINI.md, CONTRIBUTING.md, SECURITY.md, CODE_OF_CONDUCT.md — exist for GitHub readers and are never opened by the packaged app, so they leave the bundle together with the translated CHANGELOG that was already pruned. Measured on release/v3.8.51 with 51 locales: docs/i18n is 139 MB, of which 25.7 MB is the served docs/** tree (kept), 103.5 MB the CHANGELOG mirrors (already pruned) and 11.4 MB these root files (pruned now). The plan's D4 called for dropping docs/i18n entirely; that would have broken localized docs inside the app, which is why the served subtree stays.
Githab-capibara
added a commit
to Githab-capibara/OmniRoute
that referenced
this pull request
Sep 17, 2026
…mirror from the desktop bundle (diegosouzapw#13235) Merged as part of the owner batch of 2026-09-11. This PR had a live worktree in another session, so it sat outside the main 39. Merged on your explicit call, validated first rather than taken on trust: boarded with the other 10 worktree-held PRs into a consolidated worktree off `release/v3.8.51`. - ESLint over every changed file: no errors - `typecheck:core` clean; `check:dashboard-typecheck` OK; `check:changelog-integrity` OK - complexity 2821 / baseline 3218 and cognitive-complexity 1272 / baseline 1437 - 203 of 208 assertions green. The 5 remaining (`guide-settings-route` ×4, `hard-session-lease-bypass-inventory` ×1) reproduce on the pure tip with nothing from this batch applied. - `imageGeneration.ts` rebaselined 3259 → 3293 for diegosouzapw#12945's image-only-model guard, landed separately in diegosouzapw#13392 so nothing was pushed onto a live branch.⚠️ base-red inherited: diegosouzapw#12732 — provider count 356 vs 358 and `open-sse/utils/stream.ts` 3115 > frozen 3098, both reproducing on the pure tip.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…mirror from the desktop bundle (diegosouzapw#13235) Merged as part of the owner batch of 2026-09-11. This PR had a live worktree in another session, so it sat outside the main 39. Merged on your explicit call, validated first rather than taken on trust: boarded with the other 10 worktree-held PRs into a consolidated worktree off `release/v3.8.51`. - ESLint over every changed file: no errors - `typecheck:core` clean; `check:dashboard-typecheck` OK; `check:changelog-integrity` OK - complexity 2821 / baseline 3218 and cognitive-complexity 1272 / baseline 1437 - 203 of 208 assertions green. The 5 remaining (`guide-settings-route` ×4, `hard-session-lease-bypass-inventory` ×1) reproduce on the pure tip with nothing from this batch applied. - `imageGeneration.ts` rebaselined 3259 → 3293 for diegosouzapw#12945's image-only-model guard, landed separately in diegosouzapw#13392 so nothing was pushed onto a live branch.⚠️ base-red inherited: diegosouzapw#12732 — provider count 356 vs 358 and `open-sse/utils/stream.ts` 3115 > frozen 3098, both reproducing on the pure tip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR-5 of the locale-expansion plan (D4). The desktop bundle stops shipping the root-level files of every translated docs mirror —
README.md,llm.txt,CLAUDE.md,GEMINI.md,CONTRIBUTING.md,SECURITY.md,CODE_OF_CONDUCT.md— by extending the existinglocaleRootFilesprune rule that already removed the translatedCHANGELOG.md.Why not the whole
docs/i18n, as D4 first saidThe in-app docs route reads
docs/i18n/<locale>/docs/<section>/<FILE>.md(src/app/docs/[...slug]/page.tsx, path pinned bysrc/lib/docsI18nPath.ts). Dropping the directory would have broken localized docs inside the desktop app. The existing test already guarded this ("prunes authoring payloads without removing runtime docs"). No runtime reader exists for the locale root files (grepoversrc/andelectron/), so those are the honest scope.Measured on
release/v3.8.51(51 locales)docs/i18n<locale>/docs/**(served by the docs route)<locale>/CHANGELOG.md<locale>/{README.md, llm.txt, CLAUDE.md, GEMINI.md, CONTRIBUTING.md, SECURITY.md, CODE_OF_CONDUCT.md}Validation
tests/unit/electron-packaging.test.ts— the prune test now seedsREADME.mdandllm.txtmirrors and asserts they leave whiledocs/i18n/ko/docs/guides/ELECTRON_GUIDE.mdstays (RED → GREEN, 4/4).release/v3.8.51unit shards and Fast Quality Gates are red for every PR cut from this base; nothing here touches those areas.