fix(tests): align model-sync log assertion to shipped path redaction (base-red #12732) - #13227
Merged
diegosouzapw merged 1 commit intoSep 12, 2026
Conversation
…(base-red) tests/unit/model-sync-route.test.ts expected the persisted call-log error to be 'Invalid JSON response from /models', but the call-log write now runs the error through sanitizeErrorForLog -> errorPathRedaction, which redacts the path to <path> for stored logs (defense in depth for exported call logs). The live API response to the caller is unchanged (body.error still /models); only the persisted logs[0].error is redacted. Align the log assertion to the shipped behavior; body.error assertion stays /models. No production change — test alignment to an already-merged redaction. Refs base-red #12732.
This was referenced Sep 11, 2026
7 tasks done
Githab-capibara
added a commit
to Githab-capibara/OmniRoute
that referenced
this pull request
Sep 17, 2026
…(base-red) (diegosouzapw#13227) Merged as part of the 39-PR owner batch of 2026-09-11, validated as a unit. Boarded into one consolidated worktree cut from `release/v3.8.51` with the other 38 — zero conflicts between them. - ESLint over every changed file: no errors (the only finding was one suppression entry the batch emptied, pruned on diegosouzapw#13243) - `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, within baseline); `check:changelog-integrity` OK - complexity 2821 / baseline 3218 and cognitive-complexity 1272 / baseline 1437 — both under baseline - 256 assertions green: 246 under node:test and 10 under vitest, which is where `tests/unit/**/*.test.tsx` actually runs - `check-file-size`: `chatCore.ts` rebaselined 6144 → 6146 for diegosouzapw#13278 and diegosouzapw#13276, annotated and landed on diegosouzapw#13243⚠️ base-red inherited: diegosouzapw#12732 — the provider count (356 in the docs vs the 358 the modules define) and `open-sse/utils/stream.ts` at 3115 > frozen 3098 both reproduce on the pure tip with zero contribution from this batch.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…(base-red) (diegosouzapw#13227) Merged as part of the 39-PR owner batch of 2026-09-11, validated as a unit. Boarded into one consolidated worktree cut from `release/v3.8.51` with the other 38 — zero conflicts between them. - ESLint over every changed file: no errors (the only finding was one suppression entry the batch emptied, pruned on diegosouzapw#13243) - `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, within baseline); `check:changelog-integrity` OK - complexity 2821 / baseline 3218 and cognitive-complexity 1272 / baseline 1437 — both under baseline - 256 assertions green: 246 under node:test and 10 under vitest, which is where `tests/unit/**/*.test.tsx` actually runs - `check-file-size`: `chatCore.ts` rebaselined 6144 → 6146 for diegosouzapw#13278 and diegosouzapw#13276, annotated and landed on diegosouzapw#13243⚠️ base-red inherited: diegosouzapw#12732 — the provider count (356 in the docs vs the 358 the modules define) and `open-sse/utils/stream.ts` at 3115 > frozen 3098 both reproduce on the pure tip with zero contribution from this batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clears the one still-live code-level base-red on
release/v3.8.51:tests/unit/model-sync-route.test.tsfails on the tip.The persisted call-log error is now run through
sanitizeErrorForLog→errorPathRedaction, which redacts the path to<path>for stored logs (defense in depth — call logs get exported). The live API response to the caller is unchanged (body.erroris still/models); only the storedlogs[0].erroris redacted. The test still expected the pre-redaction/modelson the log assertion.Align
logs[0].errorto<path>;body.errorstays/models. No production change — a test-only alignment to already-shipped redaction.Verification
node --import tsx/esm --test tests/unit/model-sync-route.test.ts→ 18/18 pass. prettier clean.The base tip is red under #12732, but that verdict is stale — the release-green continuous runs keep getting cancelled by concurrent merges, so the issue never refreshes. Re-checked each of its 5 HARD failures against the current tip:
#12058 canonical modeunit → passes now (4/4), stale.chat pipeline persists Codex responses cache/reasoning to call logsintegration → passes now (28/28), stale (and not caused by P2b'svideo_content_removedcolumn).check:agent-skills-sync→ passes now (exit 0), stale.Package artifact: Build provenance check failed+Tarball boot-smoke→ build/infra (needs a real pack build; not a code defect this PR touches).This PR fixes the only code-level red that still reproduces. CI red on this PR is inherited from #12732; the build/infra items will clear on a fresh idle release-green run.