Repository navigation
chore(quality): rebaseline chatCore.ts after the non-streaming regression fixes - #13045
Merged
diegosouzapw merged 1 commit intoSep 8, 2026
Conversation
This was referenced Sep 8, 2026
HouMinXi
added a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Sep 10, 2026
The wrap lives in responsesJsonToSse.ts. chatCore.ts only stamps the client-stream flag and swaps the non-streaming return (+6 on diegosouzapw#13045's 6021). Signed-off-by: Minxi Hou <houminxi@gmail.com>
HouMinXi
added a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Sep 10, 2026
The wrap lives in responsesJsonToSse.ts. chatCore.ts only stamps the client-stream flag and swaps the non-streaming return (+6 on diegosouzapw#13045's 6021). Signed-off-by: Minxi Hou <houminxi@gmail.com>
HouMinXi
added a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Sep 11, 2026
The wrap lives in responsesJsonToSse.ts. chatCore.ts only stamps the client-stream flag and swaps the non-streaming return (+6 on diegosouzapw#13045's 6021). Signed-off-by: Minxi Hou <houminxi@gmail.com>
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…sion fixes (diegosouzapw#13045) Cap de arquivo estourado por mim: mergeei o diegosouzapw#12963 e o diegosouzapw#12990 sem rebaselinar o `chatCore.ts`, que ambos fazem crescer. Cada um passou no próprio gate porque mediu contra o tip de onde saiu — o cap só estoura no conjunto, que é o padrão registrado sete vezes no handoff da campanha anterior. 5984 → 6021, +37 linhas, irredutíveis nos chokepoints existentes: cada edição fica onde o `chatCore` já toma a decisão, e os helpers estão sob o cap. Coberto por `chatcore-translation-paths` (72/74; as 2 abertas são a issue diegosouzapw#13043).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base-red, e é meu
Mergeei o #12963 e o #12990 sem rebaselinar o arquivo que ambos fazem crescer. Os dois passaram nos próprios gates porque cada um mediu contra o tip de onde saiu; o cap só estoura no conjunto — exatamente o padrão que o handoff da campanha anterior registrou sete vezes, e que eu repeti.
Crescimento
5984 → 6021, +37 linhas, de dois PRs meus em cima do #12867:okdo resultado do leg num binding próprio. A narrowing da união discriminada se perdia na reatribuição do tool loop, gerando 13TS2339sobtsconfig.typecheck-api.json.isLocalStreamLifecycleError, oclientResponsesintético que deve ser omitido, a reconstrução doclaudePromptCacheLogMetano caminho do leg, e a identidade de fence derivada preguiçosamente e falhando fechada.Irredutível nos chokepoints existentes: cada edição fica onde o
chatCorejá toma a decisão, e os helpers (nonStreamingProviderLeg.ts,serverOwnedToolLoopWire.ts) estão sob o cap.Coberto por
tests/unit/chatcore-translation-paths.test.ts— 72/74; as 2 abertas são a issue #13043.