Skip to content

fix(providers): route Muse Spark 1.3 through Responses API - #12973

Closed
shermzy wants to merge 1 commit into
diegosouzapw:release/v3.8.51from
shermzy:fix/12674-opencode-muse-spark
Closed

shermzy wants to merge 1 commit into
diegosouzapw:release/v3.8.51from
shermzy:fix/12674-opencode-muse-spark

Conversation

@shermzy

@shermzy shermzy commented Sep 7, 2026

Copy link
Copy Markdown

Summary

  • Register opencode-go/muse-spark-1.3-contributor and its minimal, low, medium, high, and xhigh variants with the Responses wire format.
  • Teach the OpenCode executor about the 1.3 effort-tier aliases.
  • Add focused registry, executor URL, effort parsing, and combo coverage.

Fixes #12674

Validation

  • npm run typecheck:core — passed.
  • Targeted ESLint — passed.
  • Focused issue and neighboring tests — 66 passed.
  • Controlled full Vitest run — 51 files / 465 tests passed.
  • Commit hooks — passed (Prettier, ESLint, docs sync, budget, tracked-artifact checks).
  • npm run build was started but stopped after the shared host reached approximately 9.3 GB build memory with about 0.5 GB free; no compiler diagnostic had appeared.
  • npm run test:unit was started but stopped during the repository's large process-isolated suite; the issue-specific tests passed before the stop.

Release note

The target branch currently has open base-red issue #12732, so merge should wait for the release-drain failures to clear.

maxmad64bis pushed a commit to maxmad64bis/OmniRoute that referenced this pull request Sep 12, 2026
… Zen, OpenCode and OpenCode Go

Muse Spark 1.3 is only served on the Responses API, like 1.2. None of the
1.3 ids were registered with targetFormat "openai-responses", so the
executor fell back to /chat/completions and the upstream answered 500.

- opencode-go: muse-spark-1.3-contributor and its minimal/low/medium/high/xhigh
  effort aliases, plus the 1.3 effort tiers in the executor (from diegosouzapw#12675).
- opencode-zen and opencode: muse-spark-1.3 and muse-spark-1.3-contributor-free.
- All 1.3 entries declare contextLength 1048576 and maxOutputTokens 131072,
  matching the published OpenCode catalog and the 1.2 entries, instead of the
  200000 provider default.

Builds on diegosouzapw#12675, and on the same fix proposed in diegosouzapw#12973 and diegosouzapw#13111.

Co-authored-by: bacnh85 <mail@bacnh.com>
@diegosouzapw

Copy link
Copy Markdown
Owner

Thanks for this fix — the core approach (registry targetFormat + EFFORT_TIERS) is correct and your test that actually calls OpencodeExecutor.execute() with a mocked fetch to assert the real dispatch URL is genuinely stronger than the other PRs on this issue.

The issue's own follow-up (from the maintainer) asks for the fix to also cover the opencode-zen registry and the base opencode registry, not just opencode-go — PR #13111 already covers all three. To avoid duplicate registry entries we're planning to merge #13111 and port your dispatch-URL test into it with credit to you. Let us know if you'd rather extend this PR to cover the other two registries instead — happy to go either way.

Triage note: this is the review recommendation — the close itself happens only after the maintainer's per-PR sign-off (and, where a superseding PR is named, after it has landed). Nothing is being closed by this comment.

diegosouzapw pushed a commit that referenced this pull request Sep 15, 2026
… Zen, OpenCode and OpenCode Go (#13471)

Registers Muse Spark 1.3 (with its effort aliases) on OpenCode Zen, OpenCode and OpenCode Go with `targetFormat: openai-responses` and a 1M context window, so the model no longer falls back to `/chat/completions` (#12674, #12698). Superset of #12675, #12973 and #13111, whose authors are credited in the PR.

Validated first on the combined board of all 38 PRs of this batch (10 merged as-is, 28 after the maintainer rework) on top of release/v3.8.51 c0f92ec: typecheck:core, check:open-sse-typecheck and check:dashboard-typecheck clean; ESLint clean on every changed file; file-size (rebaselined for the combined growth), complexity, cognitive-complexity, changelog-integrity, docs-counts, docs-sync, migration-numbering and i18n new-key gates green; 735 focused node:test cases with the only batch-caused failure (a flag-count assertion) fixed. Then re-validated alone on the fresh release tip right before this merge: ESLint on the changed files, typecheck:core, check:open-sse-typecheck, the file-size/complexity/changelog gates and this PR's own tests.

Thanks @maxmad64bis!
@diegosouzapw

Copy link
Copy Markdown
Owner

Thanks for catching this! Muse Spark 1.3 routing through the Responses API landed via #13471, which covers OpenCode Zen, OpenCode and OpenCode Go plus the effort aliases and credits the parallel reports. The registry entries, getTokenLimit and resolveOpencodeTargetFormat are all covered by its tests, so this PR is now redundant. Closing as covered by #13471.

muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
… Zen, OpenCode and OpenCode Go (diegosouzapw#13471)

Registers Muse Spark 1.3 (with its effort aliases) on OpenCode Zen, OpenCode and OpenCode Go with `targetFormat: openai-responses` and a 1M context window, so the model no longer falls back to `/chat/completions` (diegosouzapw#12674, diegosouzapw#12698). Superset of diegosouzapw#12675, diegosouzapw#12973 and diegosouzapw#13111, whose authors are credited in the PR.

Validated first on the combined board of all 38 PRs of this batch (10 merged as-is, 28 after the maintainer rework) on top of release/v3.8.51 d61b804: typecheck:core, check:open-sse-typecheck and check:dashboard-typecheck clean; ESLint clean on every changed file; file-size (rebaselined for the combined growth), complexity, cognitive-complexity, changelog-integrity, docs-counts, docs-sync, migration-numbering and i18n new-key gates green; 735 focused node:test cases with the only batch-caused failure (a flag-count assertion) fixed. Then re-validated alone on the fresh release tip right before this merge: ESLint on the changed files, typecheck:core, check:open-sse-typecheck, the file-size/complexity/changelog gates and this PR's own tests.

Thanks @maxmad64bis!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(providers): opencode-go/muse-spark-1.3-contributor routed to /chat/completions, upstream serves it only on Responses

2 participants