Skip to content

fix(sse): pin the ok variant of the non-streaming leg result in chatCore #12963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 2 commits into from
Sep 8, 2026
Merged

fix(sse): pin the ok variant of the non-streaming leg result in chatCore #12963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4826fd3
style(sse): apply prettier to chatCore.ts (landed unformatted in #12867)
diegosouzapw Sep 7, 2026
09cb076
fix(sse): pin the ok variant of the non-streaming leg result in chatCore
diegosouzapw Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixes/chatcore-legresult-narrowing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Restore the API-route typecheck gate: the non-streaming leg result lost its discriminated-union narrowing after the server-owned tool loop reassignment, producing 13 new TS2339 diagnostics in `chatCore.ts`.
5 changes: 0 additions & 5 deletions config/quality/eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,6 @@
"count": 1
}
},
"open-sse/handlers/chatCore.ts": {
"@typescript-eslint/no-unused-vars": {
"count": 26
}
},
"open-sse/handlers/chatCore/executorHelpers.ts": {
"@typescript-eslint/no-unused-vars": {
"count": 1
Expand Down
Loading
Loading