Skip to content

fix(dashboard): explain silent Radar cells on hover and gate them - #12937

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
maxmad64bis:fix/batch12-radar-silent-cells
Sep 10, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
maxmad64bis:fix/batch12-radar-silent-cells

Conversation

@maxmad64bis

Copy link
Copy Markdown
Contributor

⚠️ base-red inherited: #12732

Summary

The Radar catalog table rendered absent data as bare sentinels: empty limits, unknown context windows, and unreported capabilities showed —/? with no explanation. Each now explains itself on hover, and a new check:radar-sentinels step keeps it that way.

(release/v3.8.51 not green at branch time; no new failures from this change — focused suites below are green).

Related Issues

Validation

  • Change type: UI
  • Focused tests and category gates from the golden path
  • npm run lint (targeted files only — full run in CI)
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR

Focused runs, all green: radar suite 21/21 (tests/unit/dashboard/radar-catalog-table-limits-training.test.tsx), i18n:check-ui-coverage --threshold=65 PASS, check:radar-sentinels all-invariants-hold. ERR6 evidence: fr missing 10 → 13 (+3 asserted) at --threshold=100, restore verified byte-identical (+3 lines only).

Tests Added Or Updated

  • tests/unit/dashboard/radar-catalog-table-limits-training.test.tsx (tooltip assertions ×3, explicit-false no-title, context-0 edge, EN-string pins; trainsOnPrompts no-badge contract re-pinned)

Coverage Notes

  • RadarCatalogTable.tsx tooltips covered by the extended suite. No coverage regression expected; full gate runs in CI.

Reviewer Notes

  • Three EN keys (radarPage.*UnknownHelp) inserted surgically (+3/-0 per locale, same __MISSING__:<EN> sentinel format as neighboring lines; i18n:sync-ui deliberately NOT run — it reorders every locale to EN key order and backfills 7–10 unrelated pre-existing missing keys per locale). EN shown at runtime via fallback. trainsOnPrompts: false/absent intentionally still renders no badge (shipped feat(radar): show the rate limits and training disclosure the feed already sends #12320 contract, locked by test).
  • No VPS validation applicable: UI-only tooltips, no upstream/network behavior change, values rendered unchanged.

@maxmad64bis
maxmad64bis force-pushed the fix/batch12-radar-silent-cells branch from 117ab11 to ec788d6 Compare September 7, 2026 10:53
@maxmad64bis
maxmad64bis force-pushed the fix/batch12-radar-silent-cells branch from ec788d6 to cf14390 Compare September 10, 2026 11:50
@diegosouzapw
diegosouzapw merged commit 4c10baa into diegosouzapw:release/v3.8.51 Sep 10, 2026
9 of 16 checks passed
@maxmad64bis
maxmad64bis deleted the fix/batch12-radar-silent-cells branch September 24, 2026 21:12
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…egosouzapw#12937)

Validado numa worktree combinada com a onda de dashboard/monitoring desta leva sobre `release/v3.8.51`: typecheck:core limpo, check-api-typecheck OK (289), check-file-size OK após rebaseline, 130/131 nos testes focados — a falha restante é asserção de tempo de parede sob carga, verde 6/6 isolada.

Sentinela que não se explica (`—`, `?`) faz o leitor inventar a razão. Explicar no hover é metade; o `check:radar-sentinels` é a outra — sem o gate, a explicação apodrece na primeira coluna nova.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants