fix(combos): inherit model_context_overrides onto effort-suffixed targets (#12475) - #12926
Merged
diegosouzapw merged 2 commits intoSep 7, 2026
Conversation
…gets resolveContextOverrideVerdict looked up the exact variant id (GLM-5.3-high). Overrides are stored on the base id (GLM-5.3), so the compat filter fell through to the static catalog and inverted priority order on large requests (diegosouzapw#12475). Exact variant rows still win. Suffix match is longest-first so -xhigh is not eaten by -high. Signed-off-by: Minxi Hou <houminxi@gmail.com>
Signed-off-by: Minxi Hou <houminxi@gmail.com>
diegosouzapw
merged commit Sep 7, 2026
e8a9117
into
diegosouzapw:release/v3.8.51
8 of 16 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…gets (diegosouzapw#12475) (diegosouzapw#12926) Validado numa worktree combinada com as 16 PRs desta leva sobre `release/v3.8.51`: typecheck:core limpo, check-file-size e check-changelog-integrity OK, complexity 2788/3218 e cognitive 1261/1437 (ambos sob a baseline), ESLint 0 erros nos 152 arquivos alterados, 771 testes unitários focados, 49 de integração e a suíte vitest:ui completa (2149) verdes. A busca do sufixo mais longo primeiro (`-xhigh` antes de `-high`) é o detalhe que faz a herança funcionar em vez de quase-funcionar. Manter `getResolvedModelContextOverride` fora do escopo, com o teste existente registrando que aquele caminho continua sem herança, deixa a fronteira explícita.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Effort-suffixed combo members (
GLM-5.3-high,GLM-5.3-Flash-xhigh,GLM-5.2-high) never inherited the base model'smodel_context_overridesrow. The compat filter then used the static catalog and invertedpriorityorder on large requests.Maintainer confirmed the chokepoint:
resolveContextOverrideVerdict()(open-sse/services/combo/contextOverrideGate.ts).Fixes #12475
Fix
Exact override first. If missing, strip a trailing effort tier (longest-first so
-xhighis not eaten by-high) and look up the base id.GLM-5.3-highinheritsGLM-5.3. An explicitGLM-5.3-highrow still wins. Spec entryglm-5.2-high(1M) no longer shadows a smaller persisted base override.Does not change
getResolvedModelContextOverride/ capability resolution — that path still has no effort inheritance (existing test).Tests
tests/unit/combo-effort-suffix-context-override-12475.test.ts— 5/5.Injection: drop the inherit lookup → 4 fail / 1 pass (exact-row case). Restore → 5/5.
Sibling:
combo-context-window-filter+model-context-override-readpath21/21.Not in this PR
/v1/modelseffort_tiersvs provider-advertised set (issue observation 2).getContextOverridecapability path (kept exact-match).Same Fast Quality Gates / glm arity / changelog-integrity fingerprints as sibling OPEN PRs on
release/v3.8.51. This diff does not touch those files.