fix(glm): drop extra 16th arg to SSE transform helper - #12770
Merged
diegosouzapw merged 1 commit intoSep 7, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
HouMinXi
force-pushed
the
fix/glm-sse-transform-arity
branch
from
September 5, 2026 14:31
271ec3a to
eba6c00
Compare
Contributor
Author
|
Rebased onto range-diff every unique commit Own tests re-run on the new base.
|
This was referenced Sep 5, 2026
HouMinXi
added a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Sep 6, 2026
Cherry-pick onto the deploy recut conflicted with diegosouzapw#12770 on open-sse/executors/glm.ts. This PR only fixes ConfirmModal forwarding the click event into onAfter. Restore glm.ts to the release tip so the arity fix stays on diegosouzapw#12770. Signed-off-by: Minxi Hou <houminxi@gmail.com>
HouMinXi
force-pushed
the
fix/glm-sse-transform-arity
branch
from
September 6, 2026 08:09
eba6c00 to
d2758f5
Compare
HouMinXi
added a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Sep 6, 2026
Cherry-pick onto the deploy recut conflicted with diegosouzapw#12770 on open-sse/executors/glm.ts. This PR only fixes ConfirmModal forwarding the click event into onAfter. Restore glm.ts to the release tip so the arity fix stays on diegosouzapw#12770. Signed-off-by: Minxi Hou <houminxi@gmail.com>
Contributor
Author
This was referenced Sep 6, 2026
HouMinXi
added a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Sep 7, 2026
Cherry-pick onto the deploy recut conflicted with diegosouzapw#12770 on open-sse/executors/glm.ts. This PR only fixes ConfirmModal forwarding the click event into onAfter. Restore glm.ts to the release tip so the arity fix stays on diegosouzapw#12770. Signed-off-by: Minxi Hou <houminxi@gmail.com>
createSSETransformStreamWithLogger takes 15 parameters. The 65536 positional was a TS2554 and never reached TransformStream. Last arg is suppressThinkClose. Signed-off-by: Minxi Hou <houminxi@gmail.com>
HouMinXi
force-pushed
the
fix/glm-sse-transform-arity
branch
from
September 7, 2026 02:36
d2758f5 to
e55abbf
Compare
Contributor
Author
|
Rebased onto
|
diegosouzapw
merged commit Sep 7, 2026
d857bd0
into
diegosouzapw:release/v3.8.51
9 of 16 checks passed
Merged
8 tasks done
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…2770) Validado numa worktree combinada com as 16 PRs desta leva sobre `release/v3.8.51`: typecheck:core limpo, check-file-size e check-changelog-integrity OK, complexity 2788/3218 e cognitive 1261/1437 (ambos sob a baseline), ESLint 0 erros nos 152 arquivos alterados, 771 testes unitários focados, 49 de integração e a suíte vitest:ui completa (2149) verdes. O `65536` era o 16º posicional de um helper com 15 parâmetros — `TS2554` vivo no tip (`open-sse/executors/glm.ts:244`, confirmado aqui antes do board). O teste de guarda de aridade é o que impede a reincidência: ele checa a assinatura do helper e o call site, não o comportamento, que é exatamente onde o erro morava. Obrigado por isolar isso do diegosouzapw#12711 em vez de deixar o `glm.ts` viajar junto com pin/combo-split/moonshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translateSseResponseinopen-sse/executors/glm.tspassed a 16th positional (65536) tocreateSSETransformStreamWithLogger. That helper has 15 parameters (open-sse/utils/stream.ts:2998-3013); last isrequestToolIdentityMap. tsc reports TS2554. The number never reachedTransformStream. The old comment about a 64KB buffer was wrong.This is the same one-line drop that landed inside #12711. Isolated here so pin / combo-split / moonshot do not have to carry
glm.ts.Fix
Drop
undefined, undefined, 65536. Last argument stayssuppressThinkClose. Comment now matches the helper.Tests
tests/unit/glm-sse-transform-arity.test.ts— source guard: helper has nohighWaterMarkslot; GLM call site has no65536and ends onsuppressThinkClose.tests/unit/glm-think-close-marker-leak.test.tsstill green (3/3).65536back → arity test red. Restore → 2/2 green.KeyHealth/translateJsonResponseunused on tip are not in this diff.Not in this PR
reset-aware-model-family.mdmissing-(🔴 Release branch not green: release/v3.8.51 #12732)cli-tunnelskill dry-run generateContributor only — not merging.