Conversation
This was referenced Sep 5, 2026
Closed
backryun
force-pushed
the
codex/test-quick-tier-12589
branch
2 times, most recently
from
September 6, 2026 23:18
35240e5 to
779c57c
Compare
backryun
force-pushed
the
codex/test-quick-tier-12589
branch
2 times, most recently
from
September 7, 2026 22:34
d3c01e2 to
c9a56fd
Compare
Moves all ~4.3k tests/unit/*.test.* files into per-prefix subdirectories (e.g. chatcore/, combo/, translator/, cli/, db/, provider/) plus misc/ for the unclassifiable tail. No test logic changed except one-level-deeper relative import/path fixes. Syncs the 4 runner-glob owners (package.json test:unit scripts, check-test-discovery.mjs, build-test-impact-map.mjs, merge-train.sh), renames quality-baseline keys (file-size, eslint-suppressions, test-masking-allowlist), and updates docs/ test-path references so the fabricated-docs, test-discovery, file-size and masking gates stay green. Refs diegosouzapw#12539
- stryker.conf.json: remap 338 tap.testFiles entries from flat tests/unit/*.test.ts paths to their new per-prefix subdirs (fixes check:mutation-test-coverage --strict). - tests/unit/serial/: evict refresh-serializer*.test.ts misclassified by substring match into the concurrency quarantine; they belong to oauth/. Drop serial from the parallel runner brace so the quarantine is not double-executed (fixes test-serial-quarantine).
claude-fable, embedding-clova, obscura, provider-cost-data, translator-clova-v3 -> per-prefix subdirs. flat = 0 again.
… tier split The suite relocation left tests/unit/db/db-pre-migration-backup-retention-10421.test.ts importing ../../src (resolves to tests/src), and merge-train.sh / TIA omitted the moonshot and seekai prefixes that test:unit actually runs. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
…tegration glob Moves 8 slow hermetic suites (batch-e2e 150s, live-ws-heartbeat 54s, resilience-http 36s, +5) to tests/integration/e2e/ with a dedicated test:integration:e2e script, and 7 upstream-gated suites (live-gemini*, gemini-live-429, codex-chat-reasoning, wire-capture) to tests/integration/live/ with test:integration:live. Shared helpers used by both tiers stay at tests/integration/ root; tier-private helpers move along. CI runs both tiers after the default suite so no assertions stop running anywhere. Default test:integration: 115 -> 100 files. Pre-existing failures (combo-failover/routing assertions, resilience-http-e2e 1 case) unchanged and out of scope. Refs diegosouzapw#12539
backryun
force-pushed
the
codex/test-quick-tier-12589
branch
from
September 8, 2026 20:23
c9a56fd to
68b7baa
Compare
5 of 7 tasks
Contributor
Author
|
Superseded by #13163, which rebuilds the useful deterministic fixture changes as one focused commit on the current release base. The replacement preserves existing test paths and CI collection. This branch is retained for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quick tier previously stopped at nine sequential command-line batches. This continuation gives each phase one scheduler, preserves process isolation, and removes measured timer and host-environment dependencies from fixtures. The earlier local comparison of the same 3,903 selected files at concurrency 8 improved from 391.26s to 310.36s (20.7%); that benchmark predates this base refresh and has not been repeated.
Depends on #12588, then #12606. Restacked onto release/v3.8.51 at d6f3150. The release-relative diff includes both parents because their branches live on a fork. Review this continuation's four commits / 24 files in the incremental parent comparison.
Changes:
Current validation on Node 24.20.0:
Refs #12539 and #12589. Landing order remains #12588 → #12606 → this continuation.