chore(deps): pin browserslist override to ^4.28.8 - #12592
Merged
diegosouzapw merged 1 commit intoSep 5, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
The `browserslist` library is pulled in transitively through `@yarnpkg/parsers`,
`monaco-editor`, and `vite`. Recent sub-dependents (autoprefixer >=10.5.0,
caniuse-lite via vite 8) require browserslist >= 4.28.8 to parse the
'last-N-versions' query syntax. Without this override, `npm install` resolves
browserslist to ^4.27.x, which causes:
RangeError: Out of range argument
at Object.parse (node:internal/querystring:159:23)
at parseDataQuery (.../browserslist/node.js:...)
on cold installs with node 22. Pinning the override removes the failure mode
without changing the direct dependency tree.
This is a 1-line cherry-pick of 6da8329cb (the only
genuinely portable delta in that commit; the rest of 6da8329 bundles
fork-internal files).
Cherry-picked SHA: 6da8329 (rebuilt as 1-line delta after re-verification
that the other 3 files in the original commit are no longer portable).
Test: `rm -rf node_modules && npm ci && npm run build` should complete
without the RangeError above.
2 of 5 tasks
Contributor
Author
Note (transparency)I'm posting this on the PRs I opened during a self-imposed WAITING window. There's a pending handoff in my local state ( What I'm doing now:
If any of these PRs shouldn't have been opened in your view, the comment-thread on each is the right place to flag it — I'll defer. Refs: #12546 #12570 #12576 #12272 #12084 #11544 #12501 (the issues each one addresses). — KooshaPari |
diegosouzapw
merged commit Sep 5, 2026
8c4fb8f
into
diegosouzapw:release/v3.8.51
15 of 16 checks passed
This was referenced Sep 10, 2026
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
Merged. One line in `overrides`, low blast radius, and pinning a transitive that every build tool reads is defensible on its own. Validated on `release/v3.8.51`: `package.json` re-parses, `typecheck:core` clean, `check-file-size` OK. For future dependency pins, a line in the body about what the floating range actually broke (a specific build failure, a CVE, a resolution conflict) makes these reviewable without guessing. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line
package.jsonoverride pinningbrowserslistto^4.28.8to fix a cold-installRangeError: Out of range argumentin node 22 when downstream tooling (autoprefixer >=10.5.0, caniuse-lite via vite 8) requires the newer query-parser.Why
Without this override,
npm installresolves browserslist to ^4.27.x, which fails on the'last-N-versions'query syntax with:The
browserslistlibrary is pulled in transitively through@yarnpkg/parsers,monaco-editor, andvite. Pinning the override removes the failure mode without changing the direct dependency tree.Change
"overrides": { + "browserslist": "^4.28.8", "onnxruntime-node": "1.24.3",Test
Expected: clean install, no
RangeError.Provenance
This is a re-built 1-line delta from
KooshaPari/OmniRoute@6da8329cb. The original commit also modifiedREADME.md,config/quality/eslint-suppressions.json, andconfig/quality/quality-baseline.json; those changes have already landed on upstreamrelease/v3.8.51(or were re-baselined). Only this singlepackage.jsonline remains portable as of 2026-09-03.W-class: P (portable)
Cherry-pick source:
KooshaPari/OmniRoute@6da8329cbCherry-pick commit:
e2147aee7(1 file, +1)