fix(build): deduplicate required artifact paths - #12422
Merged
Merged
Conversation
…pack-required-path-dedup #12423 reached the same end state for scripts/build/pack-artifact-policy.ts — one justified volatileEnvPath.mjs entry with its #11437 comment — so the production change here is subsumed and takes the tip's side. What survives is the duplicate guard test, which does not exist on the tip and which was verified by re-introducing the duplicate and watching it fail.
diegosouzapw
marked this pull request as ready for review
September 2, 2026 13:22
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…diegosouzapw#12422) Reduced on merge rather than closed, because the useful half is not subsumed. The production change is: diegosouzapw#12423 landed first and reached the same end state for scripts/build/pack-artifact-policy.ts — one volatileEnvPath.mjs entry, keeping the diegosouzapw#11437 comment that explains why it is REQUIRED (bin/omniroute.mjs calls describeVolatileEnvWarning on every CLI boot, and bin/cli/ is only an allowlist prefix, so its absence would otherwise be silent). This PR's base carried three occurrences and reduced them to one; the tip is already there, so that file takes the tip's side. What survives is the guard test, which does not exist on the tip: it asserts the four artifact path policy arrays contain no duplicate entries, so the class of defect cannot come back quietly. Verified by proof rather than assumption — re-introducing the duplicate makes it fail, removing it makes it pass again. Verified: 18/18 in pack-artifact-policy after the reduction. Thanks — the duplicate was real and the guard is the part worth keeping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OWN SCOPE: PASS · CI: BASE-RED
The live release listed
bin/cli/utils/volatileEnvPath.mjstwice inPACK_ARTIFACT_REQUIRED_PATHS. The duplicate made missing-artifact reports contain the same pathtwice and left the policy source internally inconsistent.
This PR:
remain intact;
paths.
RED to GREEN
cabbbe410a31606085babin/cli/utils/volatileEnvPath.mjsgit diff --checkAll Node test commands used an explicit fresh temporary
DATA_DIR. No live OmniRoute database orbackup was accessed.
Independent base red
GitHub's
API Route Typecheckis red on the unrelatedsrc/app/api/memory/rerank-providers/route.tsTS2307. This two-file PR changes no API route,database module, TypeScript baseline, package manifest, or tsconfig. The same error was reproduced
on the release source and is repaired independently by open PR #12421, whose exact candidate gate
is green. Until that separate PR is merged by the owner, this PR remains correctly classified as
BASE-RED, notPR-RED.Scope
scripts/build/pack-artifact-policy.tstests/unit/pack-artifact-policy.test.tsThe branch was created directly from live
release/v3.8.51@cabbbe410a. No merge, automerge,deployment, release, dependency change, or baseline rewrite is performed.