Skip to content

fix(quality): clear base-reds on release/v3.8.51 — radar i18n EN keys + stream gates - #12331

Closed
maxmad64bis wants to merge 1 commit into
diegosouzapw:release/v3.8.51from
maxmad64bis:fix/release-v3.8.51-basereds
Closed

maxmad64bis wants to merge 1 commit into
diegosouzapw:release/v3.8.51from
maxmad64bis:fix/release-v3.8.51-basereds

Conversation

@maxmad64bis

@maxmad64bis maxmad64bis commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Base-red fix (own PR per AGENTS.md § Base-green check — never inside the feature branch inheriting the red). Drains the 4 red gates on tip 438db55 (release/v3.8.51) inherited by #12214/#12317.

Related Issues

Validation

  • Change type: i18n / other (quality gates)
  • Focused tests and category gates from the golden path — npm run i18n:check-ui-coverage PASS, i18n:check-value-drift FAIL pre-existing on tip 438db55 (2 EN rewrites, 35 stale — untouched), check:dashboard-typecheck FAIL pre-existing on tip (2 jsonView.ts/useTimestampTitles.ts TS2307 on clean tip)
  • Focused unit tests rerun after rebase: i18n-missing-placeholder-fallback 4/4, settings-i18n-keys 10/10, stream-passthrough-usage-estimation 6/6, stream-utils 40/40, i18n-vi-completeness 5/5 green in this worktree
  • npm run lint — No new ESLint warnings green on this PR (was red on tip due to collectSSE)
  • Reconciled with current active release base (438db55); no rebase pending
  • Production code changes — no runtime change; updated tests in this PR cover the behavior

Tests Added Or Updated

  • tests/unit/stream-passthrough-usage-estimation.test.ts — drop dead helper (stays 6/6)
  • tests/unit/stream-utils.test.ts — update forwards OpenAI usage-only empty choices chunks for post-fix(sse): estimate usage in passthrough stream even with include_usage #12151 behavior (estimated vs trailing tradeoff)
  • tests/unit/i18n-missing-placeholder-fallback.test.ts and tests/unit/settings-i18n-keys.test.ts — untouched, green again via en.json
  • tests/unit/i18n-vi-completeness.test.ts — green again via vi.json

Coverage Notes

  • No change in src//open-sse//electron//bin/ beyond src/i18n/messages/*.json (i18n data). No coverage impact.

Reviewer Notes

  • No migration, no flag, no runtime change. i18n:check-value-drift and check:dashboard-typecheck stay red on tip and here — pre-existing, out of scope for this base-red (same as prior fix/basereds). exclusive-connection-leases flaked once as database is locked (race, not touched).

Closed as duplicate of #12327 (1586476) which landed the same scope more completely (real stream.ts fix + pt-BR alongside vi).

… + stream gates

Docs diegosouzapw#12320 added radarPage.colLimits / trainsOnPrompts /
trainsOnPromptsHelp as __MISSING__ in 42 locales but never added the
EN source. That broke two gates: i18n-missing-placeholder-fallback
(diegosouzapw#7258, "__MISSING__ after EN fallback") and settings-i18n-keys
("direct translation calls have English messages"). Add the three EN
keys (values are the sentinels' English text).

diegosouzapw#12151 changed passthrough to estimate usage on finish without usage
when content exists and to drop the trailing choices:[] valid usage
once estimated. tests/unit/stream-utils "forwards OpenAI usage-only
empty choices chunks" still expected the old forward. Update it to
assert estimated:true and no choices:[] (same tradeoff documented in
stream-passthrough-usage-estimation).

Also drops the dead collectSSE helper in stream-passthrough-usage-
estimation.test.ts (3 unused identifiers) that reds No new ESLint
warnings — same as already-merged fix/release-v3.8.51-eslint-unused-
collectsse.

Reproduced on pure tip 438db55: 4 RED (ESLint, i18n-missing-fallback,
settings-i18n-keys, stream-utils ×2 via TIA + shard 4/4). After:
4 suites pass locally (i18n-missing, settings-i18n-keys, stream-
passthrough, stream-utils 40/40).
@maxmad64bis
maxmad64bis force-pushed the fix/release-v3.8.51-basereds branch from b91b856 to 7a3f849 Compare September 1, 2026 19:17
@maxmad64bis maxmad64bis closed this Sep 1, 2026
@maxmad64bis

Copy link
Copy Markdown
Contributor Author

Closing — duplicate of #12327 which merged in the meantime (1586476 fix(release): drain the 2026-09-01 base-red window).

Same scope (radarPage EN + stream gates) handled more completely there: estimated usage leak in passthrough fixed in stream.ts (not just the test), plus pt-BR alongside vi. This PR (7a3f849) would only re-apply half the stream-utils side and overwrite the deeper fix.

Base is green again — #12214 and #12317 benefited.

@maxmad64bis
maxmad64bis deleted the fix/release-v3.8.51-basereds branch September 24, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant