Repository navigation
fix(quality): clear base-reds on release/v3.8.51 — radar i18n EN keys + stream gates - #12331
Closed
maxmad64bis wants to merge 1 commit into
Closed
maxmad64bis wants to merge 1 commit into
maxmad64bis wants to merge 1 commit into
Conversation
… + stream gates Docs diegosouzapw#12320 added radarPage.colLimits / trainsOnPrompts / trainsOnPromptsHelp as __MISSING__ in 42 locales but never added the EN source. That broke two gates: i18n-missing-placeholder-fallback (diegosouzapw#7258, "__MISSING__ after EN fallback") and settings-i18n-keys ("direct translation calls have English messages"). Add the three EN keys (values are the sentinels' English text). diegosouzapw#12151 changed passthrough to estimate usage on finish without usage when content exists and to drop the trailing choices:[] valid usage once estimated. tests/unit/stream-utils "forwards OpenAI usage-only empty choices chunks" still expected the old forward. Update it to assert estimated:true and no choices:[] (same tradeoff documented in stream-passthrough-usage-estimation). Also drops the dead collectSSE helper in stream-passthrough-usage- estimation.test.ts (3 unused identifiers) that reds No new ESLint warnings — same as already-merged fix/release-v3.8.51-eslint-unused- collectsse. Reproduced on pure tip 438db55: 4 RED (ESLint, i18n-missing-fallback, settings-i18n-keys, stream-utils ×2 via TIA + shard 4/4). After: 4 suites pass locally (i18n-missing, settings-i18n-keys, stream- passthrough, stream-utils 40/40).
maxmad64bis
force-pushed
the
fix/release-v3.8.51-basereds
branch
from
September 1, 2026 19:17
b91b856 to
7a3f849
Compare
Contributor
Author
|
Closing — duplicate of #12327 which merged in the meantime (1586476 fix(release): drain the 2026-09-01 base-red window). Same scope (radarPage EN + stream gates) handled more completely there: estimated usage leak in passthrough fixed in stream.ts (not just the test), plus pt-BR alongside vi. This PR (7a3f849) would only re-apply half the stream-utils side and overwrite the deeper fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base-red fix (own PR per
AGENTS.md§ Base-green check — never inside the feature branch inheriting the red). Drains the 4 red gates on tip438db55(release/v3.8.51) inherited by #12214/#12317.src/i18n/messages/en.json— addradarPage.colLimits / trainsOnPrompts / trainsOnPromptsHelp(values = English text of the__MISSING__sentinels left by feat(radar): show the rate limits and training disclosure the feed already sends #12320). Without EN,deepMergeFallbackhad nothing to substitute andRadarCatalogTable.tsx:223/325/327failed the key scanner.src/i18n/messages/vi.json— same trio without__MISSING__(vi requires zero__MISSING__,i18n-vi-completeness).tests/unit/stream-passthrough-usage-estimation.test.ts— drop deadcollectSSEhelper (3no-unused-vars, fix(sse): estimate usage in passthrough stream even with include_usage #12151, same asfix/release-v3.8.51-eslint-unused-collectsse3b1520b).tests/unit/stream-utils.test.ts—forwards OpenAI usage-only empty choices chunksexpected trailingchoices:[]to be forwarded; fix(sse): estimate usage in passthrough stream even with include_usage #12151 now injectsusage.estimated:trueonstopand drops the trailing (passthroughForwardedUsage). Update toestimated:true/doesNotMatch choices:[](tradeoff documented instream-passthrough-usage-estimation).Related Issues
UNSTABLE)Validation
npm run i18n:check-ui-coveragePASS,i18n:check-value-driftFAIL pre-existing on tip438db55(2 EN rewrites, 35 stale — untouched),check:dashboard-typecheckFAIL pre-existing on tip (2jsonView.ts/useTimestampTitles.tsTS2307on clean tip)i18n-missing-placeholder-fallback 4/4,settings-i18n-keys 10/10,stream-passthrough-usage-estimation 6/6,stream-utils 40/40,i18n-vi-completeness 5/5green in this worktreenpm run lint—No new ESLint warningsgreen on this PR (was red on tip due tocollectSSE)438db55); no rebase pendingTests Added Or Updated
tests/unit/stream-passthrough-usage-estimation.test.ts— drop dead helper (stays 6/6)tests/unit/stream-utils.test.ts— updateforwards OpenAI usage-only empty choices chunksfor post-fix(sse): estimate usage in passthrough stream even with include_usage #12151 behavior (estimated vs trailing tradeoff)tests/unit/i18n-missing-placeholder-fallback.test.tsandtests/unit/settings-i18n-keys.test.ts— untouched, green again viaen.jsontests/unit/i18n-vi-completeness.test.ts— green again viavi.jsonCoverage Notes
src//open-sse//electron//bin/beyondsrc/i18n/messages/*.json(i18n data). No coverage impact.Reviewer Notes
i18n:check-value-driftandcheck:dashboard-typecheckstay red on tip and here — pre-existing, out of scope for this base-red (same as priorfix/basereds).exclusive-connection-leasesflaked once asdatabase is locked(race, not touched).Closed as duplicate of #12327 (
1586476) which landed the same scope more completely (realstream.tsfix +pt-BRalongsidevi).