Repository navigation
chore(deps): freeze the paired/pinned deps out of dependabot groups - #12329
Merged
Merged
Conversation
…t of dependabot groups onnxruntime-node only ever moves paired with @huggingface/transformers (already frozen, #9962/#4050) — a solo bump breaks the single-copy ABI contract test and reds every production-group PR. eslint-plugin-react-hooks stays pinned to 7.0.1 by a contract test until the 7.1.1 rule set is adopted in its own PR (the #12146 migration completed today, so that adoption is now unblocked).
Owner
Author
|
Merging with |
diegosouzapw
added a commit
that referenced
this pull request
Sep 2, 2026
* chore(lint): adopt eslint-plugin-react-hooks 7.1.1 The #12146 migration (284 react-hooks compiler-rule violations resolved in 8 batches) completed on 2026-09-01, unblocking the 7.1.1 adoption the pin test was holding back. Exact pin kept in both devDependencies and overrides; the pin test moves to 7.1.1 (the dependabot-level ignore from #12329 stays — a lint plugin coupled to the compiler rules always bumps via its own reviewed PR, never riding a group). * chore(lint): lockfile for the react-hooks 7.1.1 adoption Generated with a bare 'npm install --package-lock-only' (naming the package on the CLI rewrites the devDependency with a caret, which npm 11 then rejects against the exact override). Validated on the .113 with a fresh npm ci + cold NODE_OPTIONS=8G lint:json --max-warnings 0 → exit 0 (zero new violations from the 7.1.1 rule set) and the re-pinned version test green.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…t of dependabot groups (diegosouzapw#12329) onnxruntime-node only ever moves paired with @huggingface/transformers (already frozen, diegosouzapw#9962/diegosouzapw#4050) — a solo bump breaks the single-copy ABI contract test and reds every production-group PR. eslint-plugin-react-hooks stays pinned to 7.0.1 by a contract test until the 7.1.1 rule set is adopted in its own PR (the diegosouzapw#12146 migration completed today, so that adoption is now unblocked).
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
* chore(lint): adopt eslint-plugin-react-hooks 7.1.1 The diegosouzapw#12146 migration (284 react-hooks compiler-rule violations resolved in 8 batches) completed on 2026-09-01, unblocking the 7.1.1 adoption the pin test was holding back. Exact pin kept in both devDependencies and overrides; the pin test moves to 7.1.1 (the dependabot-level ignore from diegosouzapw#12329 stays — a lint plugin coupled to the compiler rules always bumps via its own reviewed PR, never riding a group). * chore(lint): lockfile for the react-hooks 7.1.1 adoption Generated with a bare 'npm install --package-lock-only' (naming the package on the CLI rewrites the devDependency with a caret, which npm 11 then rejects against the exact override). Validated on the .113 with a fresh npm ci + cold NODE_OPTIONS=8G lint:json --max-warnings 0 → exit 0 (zero new violations from the 7.1.1 rule set) and the re-pinned version test green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both open dependabot group PRs are born red on deliberate contract tests:
onnxruntime-node 1.24.3→1.29.0violatestests/unit/onnxruntime-single-copy.test.ts— the hoisted copy must equal the exact version@huggingface/transformerspins (pair from fix(build): bump @huggingface/transformers to 4.2.0 + onnxruntime-node 1.24.3 #9962; transformers itself is already frozen in this file). The pair only ever moves together, in a deliberate migration PR.eslint-plugin-react-hooks 7.0.1→7.1.1violates the pin contract (tests/unit/eslint-react-hooks-version-pinned.test.ts). The chore(lint): resolve the 229 ESLint violations frozen in #12144 (react-hooks 7 compiler rules) in batches by dashboard area #12146 migration finished today, so adopting 7.1.1 is now viable — but in its own PR with a full cold lint run, removing the pin test in the same move; never riding a group.This adds the two ignores (with rationale comments) so the groups recreate clean. After merge,
@dependabot recreateon both PRs drops the offending packages and the remaining 14+11 healthy bumps can land.