Repository navigation
fix(ci): register native-codex-turn-pin tests in stryker tap.testFiles (base-red) - #12257
Closed
diegosouzapw wants to merge 1 commit into
Closed
diegosouzapw wants to merge 1 commit into
diegosouzapw wants to merge 1 commit into
Conversation
PRs #12240 and #10573 added tests covering accountFallback.ts and circuitBreaker.ts (both mutated modules) without listing them in stryker.conf.json tap.testFiles, so check:mutation-test-coverage --strict fails on the release/v3.8.51 tip for every PR (first exposed by #12250, a docs-only PR). Registering both files clears the drift and lets their mutant kills count in the nightly.
Owner
Author
|
Superseded by #12255, which covers the same stryker tap.testFiles registration AND aligns the two native-codex-turn-pin suites to the #12247 window gate — the second base-red layer this PR's own CI hit (Unit Tests shards 3/4 + 4/4) and did not address. Closing my narrower duplicate so #12255 lands without a double-merge race; #12250 (docs) waits on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base-red drain for
release/v3.8.51: the tip failscheck:mutation-test-coverage --strict(job Fast Quality Gates) for every PR.Root cause
#12240 and #10573 added
tests/unit/native-codex-turn-pin-10379.test.tsandtests/unit/native-codex-turn-pin-model-scoped-fallback.test.ts, which cover the mutated modulesopen-sse/services/accountFallback.tsandsrc/shared/utils/circuitBreaker.ts— but neither was registered instryker.conf.json→tap.testFiles, which that gate enforces in strict mode. First exposed by the docs-only PR #12250 (its only red is this gate; reproduced locally on the pristine tip).Fix
Register both files in
tap.testFiles(alphabetical position). Local run now:✓ No drift — every covering unit test is listed in tap.testFilesacross 4728 test files / 31 mutated modules. Their mutant kills now also count in the nightly mutation run.Config-only change to a quality-gate manifest — no production code.