fix(leases): project status lease row to lease columns so joined conn… - #12115
Merged
diegosouzapw merged 1 commit intoAug 30, 2026
Conversation
…ection PII never escapes getExclusiveConnectionLeaseStatus built the returned lease via lease(row) where lease() was rowToCamel() cast to ExclusiveConnectionLease, so the runtime object also carried the joined connectionEmail, connectionDisplayName, connectionName, connectionAuthType, and connectionProvider columns from the status query, bypassing the configuredConnectionName() privacy fencing introduced in diegosouzapw#11910. No consumer leaks today because the session-leases route whitelists five lifecycle fields, but any future consumer serializing status.lease directly would type-check fine and expose the connection owner identity. lease() is now an explicit projection of the twelve declared lease columns, so joined rows can never smuggle extra values onto the object, while the status-level fenced displayName/provider fields are unchanged. Validated by node --import tsx/esm --test tests/unit/exclusive-lease-status-projection.test.ts (failing before, passing after) plus the existing exclusive-connection-leases and session-leases-route suites.
5 tasks
diegosouzapw
merged commit Aug 30, 2026
3d15294
into
diegosouzapw:release/v3.8.51
9 of 16 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ection PII never escapes (diegosouzapw#12115) Corrige vazamento de colunas de conexão (email/nome/etc.) através do cast em `getExclusiveConnectionLeaseStatus` — a projeção agora fica restrita às colunas de lease, evitando que um futuro consumidor sirva PII sem querer via o tipo `ExclusiveConnectionLease`. Documentado como Finding 8 do seu próprio bug-audit (diegosouzapw#12113). Teste próprio (103 linhas). Validado no worktree combinado. Obrigado!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ection PII never escapes
getExclusiveConnectionLeaseStatus built the returned lease via lease(row) where lease() was rowToCamel() cast to ExclusiveConnectionLease, so the runtime object also carried the joined connectionEmail, connectionDisplayName, connectionName, connectionAuthType, and connectionProvider columns from the status query, bypassing the configuredConnectionName() privacy fencing introduced in #11910. No consumer leaks today because the session-leases route whitelists five lifecycle fields, but any future consumer serializing status.lease directly would type-check fine and expose the connection owner identity. lease() is now an explicit projection of the twelve declared lease columns, so joined rows can never smuggle extra values onto the object, while the status-level fenced displayName/provider fields are unchanged. Validated by node --import tsx/esm --test tests/unit/exclusive-lease-status-projection.test.ts (failing before, passing after) plus the existing exclusive-connection-leases and session-leases-route suites.
Summary
Related Issues
Validation
Choose the change type and focused loop from the
Contribution Golden Path. The full unit suite,
Vitest, the 60% coverage gate, and the production build all run in CI on this PR (#8329):
npm run lintTests Added Or Updated
Coverage Notes
src/,open-sse/,electron/, orbin/, explain which tests cover the change.Reviewer Notes