Repository navigation
chore(quality): type the 55 no-explicit-any sites frozen under #11924 - #11975
Merged
Merged
Conversation
Production (open-sse/utils/socksConnectorWithFamily.ts, 4 sites): every cast was redundant — undici's buildConnector.BuildOptions already has `timeout?: number | null`, socks' SocksClientOptions has `timeout?: number`, and Agent.Options' `connect` / `connectTimeout` narrow to the connector's parameter types on their own. Behaviour unchanged; check:open-sse-typecheck stays at the frozen 5. Tests (51 sites): the socks-timeout mocks now carry the real types — the patched SocksClient.createConnection is typed as the static it replaces, the fake buildConnector returns buildConnector.connector, the proxy is a SocksProxy, the dynamic import is typed as the module it loads; the e2e suite passes a SocksProxy and Agent.Options and no longer casts undici's fetch init (its RequestInit already has `dispatcher`); the isFree suites narrow getCustomModels()' JSON to a declared row shape, feed deliberately-wrong values through `unknown`, and stop casting for zod's safeParse, which takes unknown. The six files' suppression entries are removed: 1238 → 1232 files, 5487 → 5432 suppressed. ESLint without the suppressions file reports 0 problems on all six; with it, no stale entry is left. The five suites pass (4, 2, 5, 4, 4).
diegosouzapw
added a commit
to hartmark/OmniRoute
that referenced
this pull request
Aug 29, 2026
Bring inherited Fast Quality Gates / ESLint / unit-test / docs-sync fixes from diegosouzapw#11940/diegosouzapw#11955/diegosouzapw#11975. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
added a commit
to jonlwheat2-gif/OmniRoute
that referenced
this pull request
Aug 29, 2026
Bring inherited Fast Quality Gates / ESLint / unit-test / docs-sync fixes from diegosouzapw#11940/diegosouzapw#11955/diegosouzapw#11975. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
added a commit
to raheemuddin786/OmniRoute
that referenced
this pull request
Aug 29, 2026
Bring inherited Fast Quality Gates / ESLint / unit-test / docs-sync fixes from diegosouzapw#11940/diegosouzapw#11955/diegosouzapw#11975. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
added a commit
to Chewji9875/OmniRoute
that referenced
this pull request
Aug 29, 2026
Bring inherited Fast Quality Gates / ESLint / unit-test / docs-sync fixes from diegosouzapw#11940/diegosouzapw#11955/diegosouzapw#11975. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
added a commit
to KaspaPulse/omniroute-session-lease
that referenced
this pull request
Aug 29, 2026
Bring inherited Fast Quality Gates / ESLint / unit-test / docs-sync fixes from diegosouzapw#11940/diegosouzapw#11955/diegosouzapw#11975. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
added a commit
to dpozimski/OmniRoute
that referenced
this pull request
Aug 29, 2026
Bring inherited Fast Quality Gates / ESLint / unit-test / docs-sync fixes from diegosouzapw#11940/diegosouzapw#11955/diegosouzapw#11975. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
diegosouzapw
added a commit
that referenced
this pull request
Aug 29, 2026
diegosouzapw
added a commit
that referenced
this pull request
Aug 29, 2026
diegosouzapw
added a commit
that referenced
this pull request
Aug 29, 2026
This was referenced Aug 29, 2026
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ouzapw#11924 (diegosouzapw#11975) Production (open-sse/utils/socksConnectorWithFamily.ts, 4 sites): every cast was redundant — undici's buildConnector.BuildOptions already has `timeout?: number | null`, socks' SocksClientOptions has `timeout?: number`, and Agent.Options' `connect` / `connectTimeout` narrow to the connector's parameter types on their own. Behaviour unchanged; check:open-sse-typecheck stays at the frozen 5. Tests (51 sites): the socks-timeout mocks now carry the real types — the patched SocksClient.createConnection is typed as the static it replaces, the fake buildConnector returns buildConnector.connector, the proxy is a SocksProxy, the dynamic import is typed as the module it loads; the e2e suite passes a SocksProxy and Agent.Options and no longer casts undici's fetch init (its RequestInit already has `dispatcher`); the isFree suites narrow getCustomModels()' JSON to a declared row shape, feed deliberately-wrong values through `unknown`, and stop casting for zod's safeParse, which takes unknown. The six files' suppression entries are removed: 1238 → 1232 files, 5487 → 5432 suppressed. ESLint without the suppressions file reports 0 problems on all six; with it, no stale entry is left. The five suites pass (4, 2, 5, 4, 4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que muda
anyopen-sse/utils/socksConnectorWithFamily.tsbuildConnector.BuildOptions.timeout?: number | null,SocksClientOptions.timeout?: number,connect/connectTimeoutjá estreitam sozinhos. Comportamento igual;check:open-sse-typechecksegue nos 5 congeladostests/unit/socks-connect-timeout.test.tscreateConnectiontipado como a estática que substitui, fakebuildConnectordevolvebuildConnector.connector,SocksProxy, import dinâmico tipado como o módulotests/unit/socks-connect-timeout-e2e.test.tsSocksProxy+Agent.Options; ofetchdo undici já aceitadispatcherno inittests/unit/models-db-isfree.test.tsgetCustomModels()estreitado para umCustomRowdeclarado;updateCustomModeljá recebeRecord<string, unknown>tests/unit/free-models-isfree.test.tsunknown, não poranytests/unit/providerModelMutationSchema-isfree.test.tssafeParserecebeunknown— cast nenhumEntradas de supressão dos 6 arquivos removidas: 1238 → 1232 arquivos, 5487 → 5432 suprimidos (ratchet só desce).
Validação
ESLint sem o arquivo de supressões: 0 problemas nos 6 arquivos; com ele: nenhuma entrada obsoleta.
check:open-sse-typecheckOK (5 pré-existentes, baseline). Suítes: 4/4, 2/2, 5/5, 4/4, 4/4.Closes #11924