Repository navigation
chore(ci): cap the unit shards at 30 min and stop restoring stale ESLint caches - #11963
Merged
diegosouzapw merged 1 commit intoAug 29, 2026
Merged
Conversation
…int caches - quality.yml fast-unit: timeout-minutes: 30. A shard finishes in ~10 min; without a ceiling a hung test process holds the PR for GitHub's 6 h default. On 2026-08-28 shard 1/4 sat 64 min without a line of output — twice at the same spot, a timing race that vanished on the third run — while the other three shards were long green. A fast red plus a re-run beats a silent multi-hour hold. - quality.yml lint-guard + the earlier ESLint cache block: drop the `restore-keys: eslint-<os>-` fallback (#11600, P-II.1 of the v3.8.50 postmortem). The key already hashes the lint config, the suppressions file and the lockfile; the fallback restored a cache built under a DIFFERENT configuration and its stale per-file verdicts are how 215 pre-existing errors stayed invisible for a cycle. Exact key or a cold full lint — never a partial cache from another configuration. check:workflows --ratchet unchanged (194/194); check-workflows suite 32/32.
diegosouzapw
added a commit
that referenced
this pull request
Aug 29, 2026
#11600) (#11996) Fixes the blocking Lint job's own ci.yml cache: PR #11963 removed the stale restore-keys fallback from quality.yml but left ci.yml's two "Restore ESLint file cache" steps carrying the same prefix-match fallback that lets a cache from a different lint config report stale per-file verdicts. Byte-level parity with #11963's already-merged fix. Deliberately half of #11600 — the other half (run-eslint-json.mjs) is covered by PR #11983 from a parallel session, so the two don't collide on the same file.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…int caches (diegosouzapw#11963) - quality.yml fast-unit: timeout-minutes: 30. A shard finishes in ~10 min; without a ceiling a hung test process holds the PR for GitHub's 6 h default. On 2026-08-28 shard 1/4 sat 64 min without a line of output — twice at the same spot, a timing race that vanished on the third run — while the other three shards were long green. A fast red plus a re-run beats a silent multi-hour hold. - quality.yml lint-guard + the earlier ESLint cache block: drop the `restore-keys: eslint-<os>-` fallback (diegosouzapw#11600, P-II.1 of the v3.8.50 postmortem). The key already hashes the lint config, the suppressions file and the lockfile; the fallback restored a cache built under a DIFFERENT configuration and its stale per-file verdicts are how 215 pre-existing errors stayed invisible for a cycle. Exact key or a cold full lint — never a partial cache from another configuration. check:workflows --ratchet unchanged (194/194); check-workflows suite 32/32.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
diegosouzapw#11600) (diegosouzapw#11996) Fixes the blocking Lint job's own ci.yml cache: PR diegosouzapw#11963 removed the stale restore-keys fallback from quality.yml but left ci.yml's two "Restore ESLint file cache" steps carrying the same prefix-match fallback that lets a cache from a different lint config report stale per-file verdicts. Byte-level parity with diegosouzapw#11963's already-merged fix. Deliberately half of diegosouzapw#11600 — the other half (run-eslint-json.mjs) is covered by PR diegosouzapw#11983 from a parallel session, so the two don't collide on the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duas proteções que o fechamento da v3.8.50 pediu
fast-unit:timeout-minutes: 30restore-keysSem mudança de comportamento fora disso.
check:workflows --ratchet194/194;check-workflows.test.ts32/32; prettier limpo.