Skip to content

chore(quality): remove unreachable code and restore test discovery - #11950

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
backryun:codex/project-hygiene-cleanup
Sep 1, 2026
Merged

diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
backryun:codex/project-hygiene-cleanup

Conversation

@backryun

@backryun backryun commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • remove 48 verified unreachable files across detached dashboard UI, superseded quota components, unused docs/Storybook components, stale helpers, and unused OAuth CLI presentation utilities
  • remove two obsolete tests that did not exercise current production behavior
  • move the memory settings API test into the discovered Vitest tree, update it for the current response contract, and import the owning DB module directly
  • add the translator test directory to the Node unit collectors, merge-train fast path, and impacted-test selector
  • remove stale ESLint suppressions for deleted or already-clean files
  • keep documented runtime error codes distinguishable from environment variables after removing the unused API response constants module
  • tighten tracked quality debt: dead-code total 408 -> 360 and frozen test-discovery orphans 13 -> 10

This intentionally stops at static-analysis boundaries: dynamic plugin/worker/vendor entrypoints, side-effect barrels, OneProxy contracts, and tool-policy contracts are left untouched for separate review.

Validation

  • npm run test:vitest — 50 files, 459 tests passed
  • npm run typecheck:core
  • npm run check:cycles
  • npm run check:dead-code — 331 unused exports + 29 unused files = 360
  • npm run check:test-discovery — 5261 test files, 32 collectors, 10 frozen orphans
  • fabricated-docs and release-green docs regressions — 28 passed
  • npm run check:docs-all — passed
  • focused merge-train and impacted-test regressions — 25 passed
  • changed-file ESLint with the repository suppression config — passed with zero warnings
  • pre-commit lint-staged and repository policy hooks — passed
  • git diff --check

Known inherited gate failures

No runtime behavior change is intended; the production-code portion is deletion of unreachable modules plus a direct import from the existing settings DB module.

@backryun
backryun requested a review from diegosouzapw as a code owner August 28, 2026 21:31
@backryun
backryun force-pushed the codex/project-hygiene-cleanup branch 9 times, most recently from 5012e6c to 8fe3600 Compare August 29, 2026 23:05
@diegosouzapw diegosouzapw added the deferred-v3.8.52 Grande demais / suspeito para o lote atual; precisa de sessão dedicada no ciclo v3.8.52 label Aug 30, 2026
@diegosouzapw

Copy link
Copy Markdown
Owner

Marcando para o ciclo v3.8.52. Deleta 48 arquivos ("unreachable code") — CONFLICTING no momento, e o próprio corpo lista dependências em duas outras PRs ainda não mergeadas (#11955, #11957) para os gates completos passarem. Deleção grande demais para validar em lote; merece sessão dedicada para confirmar cada arquivo removido não tem consumidor remanescente.

@backryun
backryun force-pushed the codex/project-hygiene-cleanup branch 13 times, most recently from 36b35ff to 2ccc49d Compare August 31, 2026 06:53
@backryun
backryun force-pushed the codex/project-hygiene-cleanup branch 4 times, most recently from 13acca2 to 8838fe0 Compare September 1, 2026 06:29
@backryun
backryun force-pushed the codex/project-hygiene-cleanup branch 4 times, most recently from 953d6d7 to deaf050 Compare September 1, 2026 09:03
@diegosouzapw

Copy link
Copy Markdown
Owner

Validated in local merge-train on 192.168.0.113 — train of #12258 #12262 #12166 #12281 #11259 #11950 merged clean onto origin/release/v3.8.51 (f5e7095):

  • Run 1 (/opt/actions-runner-omniroute-5, train tip 85cd9119): typecheck:core, file-size, complexity ×2, changelog-integrity — all green; the test:unit step was killed by a CI job landing on that runner mid-train (workspace clobbered — infra, documented risk).
  • Run 2 (/srv/omniroute-train/.claude/worktrees/mt-green1, same 6 PRs re-boarded, fresh npm ci): unit 35768/35805 pass (/tmp/mt-unit2.log), vitest 464/465 (/tmp/mt-vitest2.log).
  • Every failure is a latency/timing assert (bounded-time, event-loop lag, cooldown windows) on a box that was never idle (3 active CI runner workers throughout). Discriminated per merge-gates §3: the 3 persistent titles reproduce identically on the pure base tip on the same box (/tmp/mt-base-isolated.log, BASE_ISOLATED_EXIT=1 — same tests, same asserts), 5 more titles reproduce on the pure base on the devbox, and the single vitest failure (provider-family-combos) also fails on main's nightly without any of these PRs. Inherited/infra — not introduced by this train.

@diegosouzapw
diegosouzapw merged commit fe5f4b0 into diegosouzapw:release/v3.8.51 Sep 1, 2026
15 of 16 checks passed
@backryun
backryun deleted the codex/project-hygiene-cleanup branch September 1, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deferred-v3.8.52 Grande demais / suspeito para o lote atual; precisa de sessão dedicada no ciclo v3.8.52

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants